Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc

Issue 2360073002: [Extensions] Isolate ExtensionFunction results_ and error_ (Closed)
Patch Set: errorwithargs Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc
diff --git a/chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc b/chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc
index 91b01fb5e488fa7db0afa01631062a4b4a201688..8d8778b812a0e9407f50384fa36dda1f59a20514 100644
--- a/chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc
+++ b/chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc
@@ -355,15 +355,16 @@ ExtensionFunction::ResponseAction InputImeCreateWindowFunction::Run() {
if (!engine)
return RespondNow(Error(kErrorNoActiveEngine));
+ std::string error;
int frame_id = engine->CreateImeWindow(
extension(), render_frame_host(),
options.url.get() ? *options.url : url::kAboutBlankURL,
options.window_type == input_ime::WINDOW_TYPE_FOLLOWCURSOR
? ui::ImeWindow::FOLLOW_CURSOR
: ui::ImeWindow::NORMAL,
- bounds, &error_);
+ bounds, &error);
if (!frame_id)
- return RespondNow(Error(error_));
+ return RespondNow(Error(error));
std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue());
result->Set("frameId", new base::FundamentalValue(frame_id));

Powered by Google App Engine
This is Rietveld 408576698