chrome/browser/extensions/api/management/chrome_management_api_delegate.h - Issue 2360073002: [Extensions] Isolate ExtensionFunction results_ and error_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/chrome_management_api_delegate.h

Issue 2360073002: [Extensions] Isolate ExtensionFunction results_ and error_ (Closed)

Patch Set: errorwithargs Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc ('K') | « chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc ('k') | chrome/browser/extensions/api/management/chrome_management_api_delegate.cc » ('j') | chrome/browser/extensions/chrome_extension_function.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/chrome_management_api_delegate.h

diff --git a/chrome/browser/extensions/api/management/chrome_management_api_delegate.h b/chrome/browser/extensions/api/management/chrome_management_api_delegate.h

index 4140ee93e1e8266f3dcad4ddf9efc5b0703442ab..87c41c06728c3a3c19e49bdc64a95513412a59ff 100644

--- a/chrome/browser/extensions/api/management/chrome_management_api_delegate.h

+++ b/chrome/browser/extensions/api/management/chrome_management_api_delegate.h

@@ -44,7 +44,8 @@ class ChromeManagementAPIDelegate : public extensions::ManagementAPIDelegate {

bool show_programmatic_uninstall_ui) const override;

bool CreateAppShortcutFunctionDelegate(

extensions::ManagementCreateAppShortcutFunction* function,

- const extensions::Extension* extension) const override;

+ const extensions::Extension* extension,

+ std::string* error) const override;

std::unique_ptr<extensions::AppForLinkDelegate>

GenerateAppForLinkFunctionDelegate(

extensions::ManagementGenerateAppForLinkFunction* function,