Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2303)

Unified Diff: chrome/browser/extensions/api/browsing_data/browsing_data_api.cc

Issue 2360073002: [Extensions] Isolate ExtensionFunction results_ and error_ (Closed)
Patch Set: errorwithargs Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
diff --git a/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc b/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
index a282a8dd84a75bb301baf9a873f6e8d0197d81d2..b15e0576bfebeb5c1805183ed5080d301481e2c0 100644
--- a/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
+++ b/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
@@ -272,7 +272,7 @@ bool BrowsingDataRemoverFunction::RunAsync() {
base::Time::FromDoubleT(ms_since_epoch / 1000.0);
removal_mask_ = GetRemovalMask();
- if (bad_message_)
+ if (bad_message())
return false;
// Check for prohibited data types.
@@ -381,7 +381,7 @@ int BrowsingDataRemoverFunction::ParseOriginTypeMask(
int BrowsingDataRemoveFunction::GetRemovalMask() {
base::DictionaryValue* data_to_remove;
if (!args_->GetDictionary(1, &data_to_remove)) {
- bad_message_ = true;
+ set_bad_message(true);
return 0;
}
@@ -392,7 +392,7 @@ int BrowsingDataRemoveFunction::GetRemovalMask() {
i.Advance()) {
bool selected = false;
if (!i.value().GetAsBoolean(&selected)) {
- bad_message_ = true;
+ set_bad_message(true);
return 0;
}
if (selected)

Powered by Google App Engine
This is Rietveld 408576698