[Extensions] Isolate ExtensionFunction results_ and error_

chrome/browser/extensions/api/browsing_data/browsing_data_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Defines the Chrome Extensions BrowsingData API functions, which entail
 // clearing browsing data, and clearing the browser's cache (which, let's be
 // honest, are the same thing), as specified in the extension API JSON.
 
 #include "chrome/browser/extensions/api/browsing_data/browsing_data_api.h"
 
@@ skipping 254 matching lines @@
 
   // base::Time takes a double that represents seconds since epoch. JavaScript
   // gives developers milliseconds, so do a quick conversion before populating
   // the object. Also, Time::FromDoubleT converts double time 0 to empty Time
   // object. So we need to do special handling here.
   remove_since_ = (ms_since_epoch == 0) ?
       base::Time::UnixEpoch() :
       base::Time::FromDoubleT(ms_since_epoch / 1000.0);
 
   removal_mask_ = GetRemovalMask();
-  if (bad_message_)
+  if (bad_message())
     return false;
 
   // Check for prohibited data types.
   if (!IsRemovalPermitted(removal_mask_, GetProfile()->GetPrefs())) {
     error_ = extension_browsing_data_api_constants::kDeleteProhibitedError;
     return false;
   }
 
   if (removal_mask_ & BrowsingDataRemover::REMOVE_PLUGIN_DATA) {
     // If we're being asked to remove plugin data, check whether it's actually
@@ skipping 88 matching lines @@
   return mask;
 }
 
 // Parses the |dataToRemove| argument to generate the removal mask. Sets
 // |bad_message_| (like EXTENSION_FUNCTION_VALIDATE would if this were a bool
 // method) if 'dataToRemove' is not present or any data-type keys don't have
 // supported (boolean) values.
 int BrowsingDataRemoveFunction::GetRemovalMask() {
   base::DictionaryValue* data_to_remove;
   if (!args_->GetDictionary(1, &data_to_remove)) {
-    bad_message_ = true;
+    set_bad_message(true);
     return 0;
   }
 
   int removal_mask = 0;
 
   for (base::DictionaryValue::Iterator i(*data_to_remove);
        !i.IsAtEnd();
        i.Advance()) {
     bool selected = false;
     if (!i.value().GetAsBoolean(&selected)) {
-      bad_message_ = true;
+      set_bad_message(true);
       return 0;
     }
     if (selected)
       removal_mask |= MaskForKey(i.key().c_str());
   }
 
   return removal_mask;
 }
 
 int BrowsingDataRemoveAppcacheFunction::GetRemovalMask() {
@@ skipping 45 matching lines @@
   return BrowsingDataRemover::REMOVE_SERVICE_WORKERS;
 }
 
 int BrowsingDataRemoveCacheStorageFunction::GetRemovalMask() {
   return BrowsingDataRemover::REMOVE_CACHE_STORAGE;
 }
 
 int BrowsingDataRemoveWebSQLFunction::GetRemovalMask() {
   return BrowsingDataRemover::REMOVE_WEBSQL;
 }