[modules] Basic support of import statements.

[modules] Basic support of import statements.

BUG=v8:1569
Committed: https://crrev.com/ca6886c0356d8efd1a507a123e63fc37e00bfea0
Cr-Commit-Position: refs/heads/master@{#39639}

[neis, 2016-09-21 20:35:18]

Description was changed from

==========
[modules] Basic support of import statements.

BUG=
==========

to

==========
[modules] Basic support of import statements.

BUG=v8:1569
==========

[neis, 2016-09-21 20:35:29]

neis@chromium.org changed reviewers:
+ adamk@chromium.org

[neis, 2016-09-21 20:38:32]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 20:38:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[neis, 2016-09-21 20:42:31]

ptal

[adamk, 2016-09-21 20:50:24]

lgtm code-wise, will try to land something to let you test this in
https://codereview.chromium.org/2361593002

[neis, 2016-09-21 20:54:49]

neis@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[neis, 2016-09-21 20:54:50]

Ross, ptal at interpreter changes.

[rmcilroy, 2016-09-22 10:18:13]

Interpreter LGTM with one request.

https://codereview.chromium.org/2360063002/diff/10001/src/interpreter/bytecod...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/2360063002/diff/10001/src/interpreter/bytecod...
src/interpreter/bytecode-generator.cc:2008: auto it =
descriptor->regular_imports().find(variable->raw_name());
Could you add some tests to test-bytecode-generator to generate expected output
for module import and export please.

[neis, 2016-09-22 16:54:16]

On 2016/09/22 10:18:13, rmcilroy wrote:
> Interpreter LGTM with one request.
> 
>
https://codereview.chromium.org/2360063002/diff/10001/src/interpreter/bytecod...
> File src/interpreter/bytecode-generator.cc (right):
> 
>
https://codereview.chromium.org/2360063002/diff/10001/src/interpreter/bytecod...
> src/interpreter/bytecode-generator.cc:2008: auto it =
> descriptor->regular_imports().find(variable->raw_name());
> Could you add some tests to test-bytecode-generator to generate expected
output
> for module import and export please.

Ok, I will do that in a separate CL (also need to adapt test-bytecode-generator
to support compiling code as a module).

[neis, 2016-09-22 16:55:02]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 16:55:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[neis, 2016-09-22 16:55:08]

The CQ bit was unchecked by neis@chromium.org

[neis, 2016-09-22 16:55:12]

The CQ bit was checked by neis@chromium.org

[commit-bot: I haz the power, 2016-09-22 16:55:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 17:28:34]

Description was changed from

==========
[modules] Basic support of import statements.

BUG=v8:1569
==========

to

==========
[modules] Basic support of import statements.

BUG=v8:1569
==========

[commit-bot: I haz the power, 2016-09-22 17:28:35]

Committed patchset #2 (id:10001)

[commit-bot: I haz the power, 2016-09-22 17:28:57]

Description was changed from

==========
[modules] Basic support of import statements.

BUG=v8:1569
==========

to

==========
[modules] Basic support of import statements.

BUG=v8:1569

Committed: https://crrev.com/ca6886c0356d8efd1a507a123e63fc37e00bfea0
Cr-Commit-Position: refs/heads/master@{#39639}
==========

[commit-bot: I haz the power, 2016-09-22 17:28:58]

Patchset 2 (id:??) landed as
https://crrev.com/ca6886c0356d8efd1a507a123e63fc37e00bfea0
Cr-Commit-Position: refs/heads/master@{#39639}