Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2360043002: Add Android Studio code style to third_party/android_platform (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Android Studio code style to third_party/android_platform Makes things like import order work correctly. BUG=620034 Committed: https://crrev.com/c62a52d34d332dea087fec7e303c61bd172c3e07 Cr-Commit-Position: refs/heads/master@{#420234}

Patch Set 1 #

Patch Set 2 : Fix two typos in docs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+359 lines, -34 lines) Patch
M docs/android_studio.md View 1 5 chunks +27 lines, -25 lines 0 comments Download
M third_party/android_platform/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/android_platform/README.chromium View 1 chunk +11 lines, -9 lines 0 comments Download
A third_party/android_platform/development/ide/intellij/codestyles/AndroidStyle.xml View 1 chunk +320 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
agrieve
4 years, 3 months ago (2016-09-21 19:59:22 UTC) #2
sgurun-gerrit only
On 2016/09/21 19:59:22, agrieve wrote: lgtm, welcome to owners!
4 years, 3 months ago (2016-09-21 20:44:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360043002/20001
4 years, 3 months ago (2016-09-22 01:40:11 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-22 01:48:48 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 01:51:07 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c62a52d34d332dea087fec7e303c61bd172c3e07
Cr-Commit-Position: refs/heads/master@{#420234}

Powered by Google App Engine
This is Rietveld 408576698