Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1323)

Issue 2359593002: Android Studio: Set Android Gradle plugin to v2.2.0 (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android Studio: Set Android Gradle plugin to v2.2.0 This appeases Android Studio 2.2. Without this, it prompts to update every time you regenerate the gradle files. BUG=620034 Committed: https://crrev.com/0c28e4fe67ab2412620634d1dff48bfd49934aeb Cr-Commit-Position: refs/heads/master@{#420224}

Patch Set 1 #

Patch Set 2 : update docs #

Patch Set 3 : Fix markdown errors #

Patch Set 4 : revert randomly changed whitespace #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -22 lines) Patch
M build/android/gradle/build.gradle.jinja View 1 chunk +1 line, -1 line 0 comments Download
M build/android/gradle/generate_gradle.py View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M docs/android_studio.md View 1 2 1 chunk +79 lines, -21 lines 2 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
agrieve
On 2016/09/20 20:37:34, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org
4 years, 3 months ago (2016-09-20 20:38:08 UTC) #3
agrieve
On 2016/09/20 20:38:08, agrieve wrote: > On 2016/09/20 20:37:34, agrieve wrote: > > mailto:agrieve@chromium.org changed ...
4 years, 3 months ago (2016-09-21 19:59:51 UTC) #6
jbudorick
lgtm w/ nit https://codereview.chromium.org/2359593002/diff/60001/docs/android_studio.md File docs/android_studio.md (right): https://codereview.chromium.org/2359593002/diff/60001/docs/android_studio.md#newcode17 docs/android_studio.md:17: * To skip it. Select "Cancel" ...
4 years, 3 months ago (2016-09-21 20:14:03 UTC) #7
agrieve
https://codereview.chromium.org/2359593002/diff/60001/docs/android_studio.md File docs/android_studio.md (right): https://codereview.chromium.org/2359593002/diff/60001/docs/android_studio.md#newcode17 docs/android_studio.md:17: * To skip it. Select "Cancel" when it comes ...
4 years, 3 months ago (2016-09-22 00:58:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359593002/60001
4 years, 3 months ago (2016-09-22 00:59:05 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-22 01:05:39 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 01:10:16 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0c28e4fe67ab2412620634d1dff48bfd49934aeb
Cr-Commit-Position: refs/heads/master@{#420224}

Powered by Google App Engine
This is Rietveld 408576698