Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 23600054: ARM: Tweak StoreKeyed. (Closed)

Created:
7 years, 3 months ago by Rodolph Perfetta
Modified:
7 years, 3 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Visibility:
Public.

Description

ARM: Tweak StoreKeyed. Avoid corrupting its input in some cases. BUG=none TEST=test/mjsunit/lithium/StoreKeyed*.js R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -66 lines) Patch
M src/arm/lithium-arm.cc View 3 chunks +15 lines, -17 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 3 chunks +29 lines, -23 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +4 lines, -2 lines 0 comments Download
A + test/mjsunit/lithium/StoreKeyed.js View 1 chunk +27 lines, -23 lines 0 comments Download
A test/mjsunit/lithium/StoreKeyedExternal.js View 1 chunk +109 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Rodolph Perfetta
more breaking down of issue 23156006.
7 years, 3 months ago (2013-09-16 12:59:07 UTC) #1
ulan
LGTM
7 years, 3 months ago (2013-09-17 11:43:01 UTC) #2
Rodolph Perfetta
7 years, 3 months ago (2013-09-17 12:37:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16771 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698