Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2359963003: MHTML: Allows 'data:' URLs to be processed using normal request processing. (Closed)

Created:
4 years, 3 months ago by dewittj
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

MHTML: Allows 'data:' URLs to be processed using normal request processing. An alternative of allowing Blink to parse data URLs for all content-types was considered, but this breaks behavior elsewhere in blink that requires fonts defined in 'data:' URLs but not referenced never be decoded. Instead, we stop sandboxing requests for 'data:' URLs and allow them to use the normal request machinery. BUG=647122 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:win7_blink_dbg,linux_precise_blink_rel,linux_precise_blink_dbg,mac10.9_blink_dbg,mac10.9_blink_rel,win7_blink_rel,mac10.10_blink_rel,mac10.11_blink_rel,mac10.11_retina_blink_rel,win10_blink_rel,linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2346293002 Cr-Commit-Position: refs/heads/master@{#420365} (cherry picked from commit 4204367ed53fb3ba794678d78e7d4fc149f17787) Committed: https://chromium.googlesource.com/chromium/src/+/329811b9f577cc8f1484ba82a46dfdb91d95fdcd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/mhtml/data-uri-font.mht View 1 chunk +254 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/mhtml/data-uri-font-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/mhtml/data-uri-font-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dewittj
4 years, 3 months ago (2016-09-22 17:54:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
329811b9f577cc8f1484ba82a46dfdb91d95fdcd.

Powered by Google App Engine
This is Rietveld 408576698