Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Issue 2346293002: MHTML: Allows 'data:' URLs to be processed using normal request processing. (Closed)

Created:
4 years, 3 months ago by dewittj
Modified:
4 years, 3 months ago
CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MHTML: Allows 'data:' URLs to be processed using normal request processing. An alternative of allowing Blink to parse data URLs for all content-types was considered, but this breaks behavior elsewhere in blink that requires fonts defined in 'data:' URLs but not referenced never be decoded. Instead, we stop sandboxing requests for 'data:' URLs and allow them to use the normal request machinery. BUG=647122 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:win7_blink_dbg,linux_precise_blink_rel,linux_precise_blink_dbg,mac10.9_blink_dbg,mac10.9_blink_rel,win7_blink_rel,mac10.10_blink_rel,mac10.11_blink_rel,mac10.11_retina_blink_rel,win10_blink_rel,linux_trusty_blink_rel Committed: https://crrev.com/4204367ed53fb3ba794678d78e7d4fc149f17787 Cr-Commit-Position: refs/heads/master@{#420365}

Patch Set 1 #

Total comments: 3

Patch Set 2 : add an expectation #

Patch Set 3 : git squash commit. #

Patch Set 4 : Adds a rebaseline line to test expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/mhtml/data-uri-font.mht View 1 2 1 chunk +254 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/mhtml/data-uri-font-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/mhtml/data-uri-font-expected.txt View 1 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 1 2 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 56 (36 generated)
dewittj
ptal, generating baselines now.
4 years, 3 months ago (2016-09-19 17:03:33 UTC) #4
Dmitry Titov
https://codereview.chromium.org/2346293002/diff/1/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp File third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp (right): https://codereview.chromium.org/2346293002/diff/1/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp#newcode450 third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp:450: // Abort the request if the archive doesn't contain ...
4 years, 3 months ago (2016-09-19 19:54:16 UTC) #14
dewittj
https://codereview.chromium.org/2346293002/diff/1/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp File third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp (right): https://codereview.chromium.org/2346293002/diff/1/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp#newcode450 third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp:450: // Abort the request if the archive doesn't contain ...
4 years, 3 months ago (2016-09-20 22:44:55 UTC) #16
dewittj
+jianli for context
4 years, 3 months ago (2016-09-20 22:46:22 UTC) #18
Dmitry Titov
lgtm, this seem to provide desired behavior. Defer to Nate for potential refactor ideas though.
4 years, 3 months ago (2016-09-21 17:58:41 UTC) #19
Nate Chapin
LGTM if you agree that my wild idea below is worse than the alternatives :) ...
4 years, 3 months ago (2016-09-21 19:30:02 UTC) #20
Nate Chapin
On 2016/09/21 19:30:02, Nate Chapin wrote: > LGTM if you agree that my wild idea ...
4 years, 3 months ago (2016-09-21 19:33:03 UTC) #21
dewittj
I think your idea has merit, but the code is complicated enough that I'm not ...
4 years, 3 months ago (2016-09-21 21:59:46 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346293002/40001
4 years, 3 months ago (2016-09-21 22:00:27 UTC) #37
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ is not running the ...
4 years, 3 months ago (2016-09-21 22:00:29 UTC) #38
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ is not running the ...
4 years, 3 months ago (2016-09-21 22:02:16 UTC) #39
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ is not running the ...
4 years, 3 months ago (2016-09-21 22:32:01 UTC) #40
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/145812)
4 years, 3 months ago (2016-09-21 22:32:44 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346293002/40001
4 years, 3 months ago (2016-09-21 22:37:41 UTC) #44
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ is not running the ...
4 years, 3 months ago (2016-09-21 22:37:43 UTC) #45
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ is not running the ...
4 years, 3 months ago (2016-09-21 23:02:07 UTC) #46
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/300663)
4 years, 3 months ago (2016-09-21 23:12:19 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346293002/60001
4 years, 3 months ago (2016-09-22 13:51:43 UTC) #52
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-22 16:16:14 UTC) #54
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 16:19:12 UTC) #56
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4204367ed53fb3ba794678d78e7d4fc149f17787
Cr-Commit-Position: refs/heads/master@{#420365}

Powered by Google App Engine
This is Rietveld 408576698