Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2305)

Unified Diff: chrome/installer/mac/app/BUILD.gn

Issue 2359953003: Fix up the Mac installer’s Info.plist, build with branding info (Closed)
Patch Set: Derive the installer's bundle ID from the main one, drop the tweak_info_plist step, add missing substitutions Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/util/branding.gni ('k') | chrome/installer/mac/app/Info.plist » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/mac/app/BUILD.gn
diff --git a/chrome/installer/mac/app/BUILD.gn b/chrome/installer/mac/app/BUILD.gn
index a84fc30592537e72a8121182833d50e9f0644ed5..dbcccf1582bfe7869f3cdc31f5b6f7bcffd899c9 100644
--- a/chrome/installer/mac/app/BUILD.gn
+++ b/chrome/installer/mac/app/BUILD.gn
@@ -2,8 +2,10 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import("//testing/test.gni")
import("//build/config/mac/rules.gni")
+import("//build/mac/tweak_info_plist.gni")
Robert Sesek 2016/09/22 14:46:56 Unused.
+import("//build/util/branding.gni")
+import("//testing/test.gni")
source_set("mac_installer_base") {
visibility = [ ":*" ]
@@ -29,8 +31,13 @@ source_set("mac_installer_base") {
}
mac_app_bundle("mac_installer_app") {
+ output_name = "$chrome_product_installer_full_name"
info_plist = "Info.plist"
- extra_substitutions = [ "MACOSX_DEPLOYMENT_TARGET=10.9" ]
+ extra_substitutions = [
+ "MACOSX_DEPLOYMENT_TARGET=10.9",
+ "PRODUCT_INSTALLER_FULLNAME=$chrome_product_installer_full_name",
+ "MAC_INSTALLER_BUNDLE_ID=$chrome_mac_bundle_id.installer",
Robert Sesek 2016/09/22 14:46:56 For consistency with chrome/BULD.gn, use CHROMIUM_
Sidney San Martín 2016/09/22 15:43:48 Done.
+ ]
sources = [
"AppDelegate.h",
"AppDelegate.mm",
« no previous file with comments | « build/util/branding.gni ('k') | chrome/installer/mac/app/Info.plist » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698