Fix up the Mac installer’s Info.plist, build with branding info

chrome/installer/mac/app/BUILD.gn

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import("//build/config/mac/rules.gni")
+import("//build/mac/tweak_info_plist.gni")

[Robert Sesek, 2016/09/22 14:46:56]

Unused.

+import("//build/util/branding.gni")
 import("//testing/test.gni")
-import("//build/config/mac/rules.gni")
 
 source_set("mac_installer_base") {
   visibility = [ ":*" ]
   sources = [
     "Downloader.h",
     "Downloader.m",
     "NSAlert+ChromeInstallerAdditions.h",
     "NSAlert+ChromeInstallerAdditions.m",
     "NSError+ChromeInstallerAdditions.h",
     "NSError+ChromeInstallerAdditions.m",
     "OmahaCommunication.h",
     "OmahaCommunication.m",
     "OmahaXMLParser.h",
     "OmahaXMLParser.m",
     "OmahaXMLRequest.h",
     "OmahaXMLRequest.m",
     "SystemInfo.h",
     "SystemInfo.m",
     "Unpacker.h",
     "Unpacker.m",
   ]
   public_configs = [ "//build/config/compiler:enable_arc" ]
 }
 
 mac_app_bundle("mac_installer_app") {
+  output_name = "$chrome_product_installer_full_name"
   info_plist = "Info.plist"
-  extra_substitutions = [ "MACOSX_DEPLOYMENT_TARGET=10.9" ]
+  extra_substitutions = [
+    "MACOSX_DEPLOYMENT_TARGET=10.9",
+    "PRODUCT_INSTALLER_FULLNAME=$chrome_product_installer_full_name",
+    "MAC_INSTALLER_BUNDLE_ID=$chrome_mac_bundle_id.installer",

[Robert Sesek, 2016/09/22 14:46:56]

For consistency with chrome/BULD.gn, use
CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id and then put the ".installer" literal
in the actual Info.plist file (see also framework-Info.plist and
helper-Info.plist for examples).

[Sidney San Martín, 2016/09/22 15:43:48]

Done.

+  ]
   sources = [
     "AppDelegate.h",
     "AppDelegate.mm",
     "AuthorizedInstall.h",
     "AuthorizedInstall.m",
     "InstallerWindowController.h",
     "InstallerWindowController.m",
     "main.m",
   ]
 
@@ skipping 44 matching lines @@
     "DiskArbitration.framework",
     "Security.framework",
   ]
   data = [
     "//chrome/test/data/mac_installer/requestCheck.dtd",
     "//chrome/test/data/mac_installer/requestSample.xml",
     "//chrome/test/data/mac_installer/responseExample.xml",
     "//chrome/test/data/mac_installer/test-dmg.dmg",
   ]
 }