Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9954)

Unified Diff: components/offline_pages/core/task_unittest.cc

Issue 2359933007: [Offline pages] Introduces TaskQueue to serialize tasks that asynchronously access SQLStore (Closed)
Patch Set: Addressing feedback from Dmitry Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/offline_pages/core/task_queue_unittest.cc ('k') | components/offline_pages/core/test_task.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/core/task_unittest.cc
diff --git a/components/offline_pages/core/task_unittest.cc b/components/offline_pages/core/task_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..0574a7933cbf955d1e1f26bb8edc2e99c3b274f1
--- /dev/null
+++ b/components/offline_pages/core/task_unittest.cc
@@ -0,0 +1,81 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/offline_pages/core/task.h"
+
+#include <memory>
+
+#include "base/bind.h"
+#include "base/test/test_simple_task_runner.h"
+#include "base/threading/thread_task_runner_handle.h"
+#include "components/offline_pages/core/test_task.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace offline_pages {
+
+using TaskState = TestTask::TaskState;
+
+class OfflineTaskTest : public testing::Test {
+ public:
+ OfflineTaskTest();
+
+ void TaskCompleted(Task* task);
+ void PumpLoop();
+
+ Task* completed_task() const { return completed_task_; }
+
+ private:
+ Task* completed_task_;
+ scoped_refptr<base::TestSimpleTaskRunner> task_runner_;
+ base::ThreadTaskRunnerHandle task_runner_handle_;
+};
+
+OfflineTaskTest::OfflineTaskTest()
+ : completed_task_(nullptr),
+ task_runner_(new base::TestSimpleTaskRunner),
+ task_runner_handle_(task_runner_) {}
+
+void OfflineTaskTest::PumpLoop() {
+ task_runner_->RunUntilIdle();
+}
+
+void OfflineTaskTest::TaskCompleted(Task* task) {
+ completed_task_ = task;
+}
+
+TEST_F(OfflineTaskTest, RunTaskStepByStep) {
+ ConsumedResource resource;
+ TestTask task(&resource);
+ task.SetTaskCompletionCallbackForTesting(
+ base::ThreadTaskRunnerHandle::Get(),
+ base::Bind(&OfflineTaskTest::TaskCompleted, base::Unretained(this)));
+
+ EXPECT_EQ(TaskState::NOT_STARTED, task.state());
+ task.Run();
+ EXPECT_EQ(TaskState::STEP_1, task.state());
+ EXPECT_TRUE(resource.HasNextStep());
+ resource.CompleteStep();
+ EXPECT_EQ(TaskState::STEP_2, task.state());
+ EXPECT_TRUE(resource.HasNextStep());
+ resource.CompleteStep();
+ EXPECT_EQ(TaskState::COMPLETED, task.state());
+ PumpLoop();
+ EXPECT_EQ(completed_task(), &task);
+}
+
+TEST_F(OfflineTaskTest, LeaveEarly) {
+ ConsumedResource resource;
+ TestTask task(&resource, true /* leave early */);
+ EXPECT_EQ(TaskState::NOT_STARTED, task.state());
+ task.Run();
+ EXPECT_EQ(TaskState::STEP_1, task.state());
+ EXPECT_TRUE(resource.HasNextStep());
+ resource.CompleteStep();
+
+ // Notice STEP_2 was omitted and task went from STEP_1 to completed.
+ EXPECT_EQ(TaskState::COMPLETED, task.state());
+ EXPECT_FALSE(resource.HasNextStep());
+}
+
+} // namespace offline_pages
« no previous file with comments | « components/offline_pages/core/task_queue_unittest.cc ('k') | components/offline_pages/core/test_task.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698