Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: components/offline_pages/core/task_queue_unittest.cc

Issue 2359933007: [Offline pages] Introduces TaskQueue to serialize tasks that asynchronously access SQLStore (Closed)
Patch Set: Addressing feedback from Dmitry Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/offline_pages/core/task_queue.cc ('k') | components/offline_pages/core/task_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/core/task_queue_unittest.cc
diff --git a/components/offline_pages/core/task_queue_unittest.cc b/components/offline_pages/core/task_queue_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..426e55efaf0c2a630be77f73c87bb892468cd999
--- /dev/null
+++ b/components/offline_pages/core/task_queue_unittest.cc
@@ -0,0 +1,123 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/offline_pages/core/task_queue.h"
+
+#include <memory>
+
+#include "base/bind.h"
+#include "base/test/test_simple_task_runner.h"
+#include "base/threading/thread_task_runner_handle.h"
+#include "components/offline_pages/core/test_task.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace offline_pages {
+
+using TaskState = TestTask::TaskState;
+
+class OfflineTaskQueueTest : public testing::Test {
+ public:
+ OfflineTaskQueueTest();
+
+ void TaskCompleted(Task* task);
+ void PumpLoop();
+
+ Task* completed_task() const { return completed_task_; }
+
+ private:
+ Task* completed_task_;
+ scoped_refptr<base::TestSimpleTaskRunner> task_runner_;
+ base::ThreadTaskRunnerHandle task_runner_handle_;
+};
+
+OfflineTaskQueueTest::OfflineTaskQueueTest()
+ : completed_task_(nullptr),
+ task_runner_(new base::TestSimpleTaskRunner),
+ task_runner_handle_(task_runner_) {}
+
+void OfflineTaskQueueTest::PumpLoop() {
+ task_runner_->RunUntilIdle();
+}
+
+void OfflineTaskQueueTest::TaskCompleted(Task* task) {
+ completed_task_ = task;
+}
+
+TEST_F(OfflineTaskQueueTest, AddAndRunSingleTask) {
+ ConsumedResource resource;
+ std::unique_ptr<TestTask> task(new TestTask(&resource));
+ TestTask* task_ptr = task.get();
+ TaskQueue queue;
+ EXPECT_EQ(TaskState::NOT_STARTED, task_ptr->state());
+ queue.AddTask(std::move(task));
+ EXPECT_TRUE(queue.HasPendingTasks());
+ EXPECT_TRUE(queue.HasRunningTask());
+ EXPECT_EQ(TaskState::STEP_1, task_ptr->state());
+ EXPECT_TRUE(resource.HasNextStep());
+ resource.CompleteStep();
+
+ EXPECT_EQ(TaskState::STEP_2, task_ptr->state());
+ EXPECT_TRUE(resource.HasNextStep());
+ resource.CompleteStep();
+
+ EXPECT_EQ(TaskState::COMPLETED, task_ptr->state());
+ EXPECT_FALSE(resource.HasNextStep());
+ PumpLoop(); // Deletes task, task_ptr is invalid after that.
+
+ EXPECT_FALSE(queue.HasRunningTask());
+ EXPECT_FALSE(queue.HasPendingTasks());
+}
+
+TEST_F(OfflineTaskQueueTest, AddAndRunMultipleTasks) {
+ ConsumedResource resource;
+ std::unique_ptr<TestTask> task_1(new TestTask(&resource));
+ TestTask* task_1_ptr = task_1.get();
+ std::unique_ptr<TestTask> task_2(new TestTask(&resource));
+ TestTask* task_2_ptr = task_2.get();
+
+ TaskQueue queue;
+ EXPECT_EQ(TaskState::NOT_STARTED, task_1_ptr->state());
+ EXPECT_EQ(TaskState::NOT_STARTED, task_2_ptr->state());
+ queue.AddTask(std::move(task_1));
+ queue.AddTask(std::move(task_2));
+ EXPECT_TRUE(queue.HasPendingTasks());
+ EXPECT_TRUE(queue.HasRunningTask());
+ EXPECT_EQ(TaskState::STEP_1, task_1_ptr->state());
+ EXPECT_EQ(TaskState::NOT_STARTED, task_2_ptr->state());
+ resource.CompleteStep();
+
+ EXPECT_EQ(TaskState::STEP_2, task_1_ptr->state());
+ EXPECT_EQ(TaskState::NOT_STARTED, task_2_ptr->state());
+ resource.CompleteStep();
+
+ EXPECT_EQ(TaskState::COMPLETED, task_1_ptr->state());
+ EXPECT_EQ(TaskState::NOT_STARTED, task_2_ptr->state());
+ PumpLoop(); // Deletes task_1, task_1_ptr is invalid after that.
+ EXPECT_EQ(TaskState::STEP_1, task_2_ptr->state());
+}
+
+TEST_F(OfflineTaskQueueTest, LeaveEarly) {
+ ConsumedResource resource;
+ std::unique_ptr<TestTask> task(
+ new TestTask(&resource, true /* leave early */));
+ TestTask* task_ptr = task.get();
+ TaskQueue queue;
+ EXPECT_EQ(TaskState::NOT_STARTED, task_ptr->state());
+ queue.AddTask(std::move(task));
+ EXPECT_TRUE(queue.HasPendingTasks());
+ EXPECT_TRUE(queue.HasRunningTask());
+ EXPECT_EQ(TaskState::STEP_1, task_ptr->state());
+ EXPECT_TRUE(resource.HasNextStep());
+ resource.CompleteStep();
+
+ // Notice STEP_2 was omitted and task went from STEP_1 to completed.
+ EXPECT_EQ(TaskState::COMPLETED, task_ptr->state());
+ EXPECT_FALSE(resource.HasNextStep());
+ PumpLoop(); // Deletes task, task_ptr is invalid after that.
+
+ EXPECT_FALSE(queue.HasPendingTasks());
+ EXPECT_FALSE(queue.HasRunningTask());
+}
+
+} // namespace offline_pages
« no previous file with comments | « components/offline_pages/core/task_queue.cc ('k') | components/offline_pages/core/task_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698