Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2359923004: Remove assert that current color is never used. (Closed)

Created:
4 years, 3 months ago by bungeman-skia
Modified:
4 years, 3 months ago
Reviewers:
borenet, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove assert that current color is never used. The COLR table format allows for use of the 'current color'. Currently the code asserts if this is used, but will use a nearby luminance grey to this color instead if the assert is ignored. Remove the assert now that this path is known to be used. BUG=skia:5788 Committed: https://skia.googlesource.com/skia/+/5f544345d653900ef30212ea1c243947be8bb074

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/ports/SkScalerContext_win_dw.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
bungeman-skia
Should fix the Win10 bots.
4 years, 3 months ago (2016-09-22 16:03:22 UTC) #8
egdaniel
lgtm
4 years, 3 months ago (2016-09-22 16:22:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359923004/1
4 years, 3 months ago (2016-09-22 16:26:13 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 19:32:12 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5f544345d653900ef30212ea1c243947be8bb074

Powered by Google App Engine
This is Rietveld 408576698