Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: src/ports/SkScalerContext_win_dw.cpp

Issue 2359923004: Remove assert that current color is never used. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ports/SkScalerContext_win_dw.cpp
diff --git a/src/ports/SkScalerContext_win_dw.cpp b/src/ports/SkScalerContext_win_dw.cpp
index c9ff5d86c35e2f8efd0eb5aec882631b0cd2fb13..0c588e8d3c9a23b12087287647fdfeed786a5cc3 100644
--- a/src/ports/SkScalerContext_win_dw.cpp
+++ b/src/ports/SkScalerContext_win_dw.cpp
@@ -808,9 +808,7 @@ void SkScalerContext_DW::generateColorGlyphImage(const SkGlyph& glyph) {
// the 'current brush' is used. fRec.getLuminanceColor() is kinda sorta what is wanted
// here, but not really, it will often be the wrong value because it wan't designed for
// this.
- // In practice, I've not encountered a color glyph that uses the current brush color.
- // If this assert ever fires, we should verify that the color is rendered properly.
- SkASSERT(false);
+ // TODO: implement this fully, bug.skia.org/5788
color = fRec.getLuminanceColor();
}
paint.setColor(color);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698