Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2359923003: MIPS: Fix compilation failures due to warnings on mips32r1 (Closed)

Created:
4 years, 3 months ago by ivica.bogosavljevic
Modified:
4 years, 3 months ago
Reviewers:
Ilija.Pavlovic1, miran.karic, akos.palfi.imgtec, ilija.pavlovic, balazs.kilvady
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix compilation failures due to warnings on mips32r1 BUG= Committed: https://crrev.com/7d482781193653741fa2c2b0af6ece34734a4df2 Cr-Commit-Position: refs/heads/master@{#39664}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M test/cctest/test-assembler-mips.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/unittests/compiler/mips/instruction-selector-mips-unittest.cc View 4 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
ivica.bogosavljevic
PTAL
4 years, 3 months ago (2016-09-22 14:41:57 UTC) #2
Ilija.Pavlovic1
lgtm
4 years, 3 months ago (2016-09-23 07:19:32 UTC) #4
Ilija.Pavlovic1
lgtm
4 years, 3 months ago (2016-09-23 07:19:34 UTC) #5
akos.palfi.imgtec
LGTM
4 years, 3 months ago (2016-09-23 08:31:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359923003/1
4 years, 3 months ago (2016-09-23 08:35:50 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build URL) v8_win_compile_dbg on ...
4 years, 3 months ago (2016-09-23 10:36:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359923003/1
4 years, 3 months ago (2016-09-23 13:19:35 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 13:23:43 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 13:23:59 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d482781193653741fa2c2b0af6ece34734a4df2
Cr-Commit-Position: refs/heads/master@{#39664}

Powered by Google App Engine
This is Rietveld 408576698