Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2359923002: Revert "Move towards using WorldImpact for codegen" (Closed)

Created:
4 years, 3 months ago by sra1
Modified:
4 years, 3 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Move towards using WorldImpact for codegen" -36% on DromeaoDRT Benchmark?benchmark=dom-query-getElementsByTagName(div) TBR=johnniwinther@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2a1ae8a3cecad9abf3a48a89f31a8aff96a4cb36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -230 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/common/codegen.dart View 4 chunks +12 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/common/registry.dart View 1 chunk +39 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 6 chunks +12 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 16 chunks +49 lines, -66 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_impact.dart View 2 chunks +1 line, -16 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart View 3 chunks +2 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_interop_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart View 5 chunks +8 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/type_variable_handler.dart View 4 chunks +2 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/types/masks.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/world_impact.dart View 2 chunks +5 lines, -62 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 4 chunks +3 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/map_tracer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/related_types.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/related_types_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/model_test_helper.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_mask_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/union_type_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (3 generated)
sra1
Committed patchset #1 (id:1) manually as 2a1ae8a3cecad9abf3a48a89f31a8aff96a4cb36 (presubmit successful).
4 years, 3 months ago (2016-09-21 17:41:28 UTC) #4
Johnni Winther
4 years, 3 months ago (2016-09-22 08:12:31 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698