Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: pkg/compiler/lib/src/common/backend_api.dart

Issue 2359923002: Revert "Move towards using WorldImpact for codegen" (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/common/codegen.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/common/backend_api.dart
diff --git a/pkg/compiler/lib/src/common/backend_api.dart b/pkg/compiler/lib/src/common/backend_api.dart
index 258a38f1c443c73303653a75207575d1051debc8..4a0d16ccaa068753fe1cfc785f0050ded1cb43cb 100644
--- a/pkg/compiler/lib/src/common/backend_api.dart
+++ b/pkg/compiler/lib/src/common/backend_api.dart
@@ -30,8 +30,7 @@ import '../patch_parser.dart'
import '../serialization/serialization.dart'
show DeserializerPlugin, SerializerPlugin;
import '../tree/tree.dart' show Node;
-import '../universe/world_impact.dart'
- show ImpactStrategy, WorldImpact, WorldImpactBuilder;
+import '../universe/world_impact.dart' show ImpactStrategy, WorldImpact;
import 'codegen.dart' show CodegenWorkItem;
import 'registry.dart' show Registry;
import 'tasks.dart' show CompilerTask;
@@ -117,8 +116,7 @@ abstract class Backend extends Target {
bool enableDeferredLoadingIfSupported(Spannable node, Registry registry);
/// Called during codegen when [constant] has been used.
- void computeImpactForCompileTimeConstant(ConstantValue constant,
- WorldImpactBuilder impactBuilder, bool isForResolution) {}
+ void registerCompileTimeConstant(ConstantValue constant, Registry registry) {}
/// Called to notify to the backend that a class is being instantiated.
// TODO(johnniwinther): Remove this. It's only called once for each [cls] and
« no previous file with comments | « no previous file | pkg/compiler/lib/src/common/codegen.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698