Convert tests that parse an Extension value to instead

Convert tests that parse an Extension value to instead
parse an entire Certificate.

(Part of a series of changes for simplifying the parsing tests to be in
terms of just certificates for consistent entry point and expectations)

BUG=634443
Committed: https://crrev.com/00d1ed465088e90594ca2c0858e5f2d13d5a3526
Cr-Commit-Position: refs/heads/master@{#420669}

[eroman, 2016-09-22 02:10:29]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 02:10:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2016-09-22 02:11:46]

eroman@chromium.org changed reviewers:
+ mattm@chromium.org

[commit-bot: I haz the power, 2016-09-22 03:29:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 03:29:31]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[eroman, 2016-09-22 06:17:42]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 06:17:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 07:24:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 07:24:58]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[eroman, 2016-09-22 20:01:48]

Description was changed from

==========
Convert the tests that parse an Extension value to instead
parsing an entire Certificate.

(Part of a series of changes for simplifying the parsing tests to be in
terms of just certificates for consistent entry point and expectations)

BUG=634443
==========

to

==========
Convert tests that parse an Extension value to instead
parse an entire Certificate.

(Part of a series of changes for simplifying the parsing tests to be in
terms of just certificates for consistent entry point and expectations)

BUG=634443
==========

[eroman, 2016-09-22 20:07:06]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 20:07:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2016-09-22 20:13:55]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 20:14:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 21:23:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 21:23:45]

Dry run: This issue passed the CQ dry run.

[mattm, 2016-09-22 22:49:20]

lgtm

[eroman, 2016-09-23 01:37:14]

The CQ bit was checked by eroman@chromium.org

[eroman, 2016-09-23 01:37:14]

The patchset sent to the CQ was uploaded after l-g-t-m from mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/2359783003/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-23 01:37:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 02:42:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 02:42:17]

Failed to apply patch for net/cert/internal/parsed_certificate.cc:
While running git apply --index -3 -p1;
  error: patch failed: net/cert/internal/parsed_certificate.cc:104
  Falling back to three-way merge...
  Applied patch to 'net/cert/internal/parsed_certificate.cc' with conflicts.
  U net/cert/internal/parsed_certificate.cc

Patch:       net/cert/internal/parsed_certificate.cc
Index: net/cert/internal/parsed_certificate.cc
diff --git a/net/cert/internal/parsed_certificate.cc
b/net/cert/internal/parsed_certificate.cc
index
6d1a071bce53e0bf04714caebd4d7eb822c2c095..e3e6417aca0d0fe12d9afd2710d89e3b3196fd08
100644
--- a/net/cert/internal/parsed_certificate.cc
+++ b/net/cert/internal/parsed_certificate.cc
@@ -79,6 +79,7 @@ scoped_refptr<ParsedCertificate>
ParsedCertificate::CreateInternal(
     DataSource source,
     const ParseCertificateOptions& options,
     CertErrors* errors) {
+  // TODO(crbug.com/634443): Add errors
   scoped_refptr<ParsedCertificate> result(new ParsedCertificate);
 
   switch (source) {
@@ -104,7 +105,7 @@ scoped_refptr<ParsedCertificate>
ParsedCertificate::CreateInternal(
   }
 
   // Attempt to parse the signature algorithm contained in the Certificate.
-  // Do not give up on failure here, since SignatureAlgorithm::CreateFromDer
+  // Do not give up on failure here, since SignatureAlgorithm::Create()
   // will fail on valid but unsupported signature algorithms.
   // TODO(mattm): should distinguish between unsupported algorithms and parsing
   // errors.

[eroman, 2016-09-23 17:03:07]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 17:03:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 18:00:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 18:00:39]

Dry run: This issue passed the CQ dry run.

[eroman, 2016-09-23 18:16:32]

The CQ bit was checked by eroman@chromium.org

[eroman, 2016-09-23 18:16:32]

The patchset sent to the CQ was uploaded after l-g-t-m from mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/2359783003/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-23 18:17:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 18:24:58]

Description was changed from

==========
Convert tests that parse an Extension value to instead
parse an entire Certificate.

(Part of a series of changes for simplifying the parsing tests to be in
terms of just certificates for consistent entry point and expectations)

BUG=634443
==========

to

==========
Convert tests that parse an Extension value to instead
parse an entire Certificate.

(Part of a series of changes for simplifying the parsing tests to be in
terms of just certificates for consistent entry point and expectations)

BUG=634443
==========

[commit-bot: I haz the power, 2016-09-23 18:24:59]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-23 18:27:17]

Description was changed from

==========
Convert tests that parse an Extension value to instead
parse an entire Certificate.

(Part of a series of changes for simplifying the parsing tests to be in
terms of just certificates for consistent entry point and expectations)

BUG=634443
==========

to

==========
Convert tests that parse an Extension value to instead
parse an entire Certificate.

(Part of a series of changes for simplifying the parsing tests to be in
terms of just certificates for consistent entry point and expectations)

BUG=634443

Committed: https://crrev.com/00d1ed465088e90594ca2c0858e5f2d13d5a3526
Cr-Commit-Position: refs/heads/master@{#420669}
==========

[commit-bot: I haz the power, 2016-09-23 18:27:18]

Patchset 6 (id:??) landed as
https://crrev.com/00d1ed465088e90594ca2c0858e5f2d13d5a3526
Cr-Commit-Position: refs/heads/master@{#420669}