net/data/parse_certificate_unittest/extension_critical_0.pem - Issue 2359783003: Convert tests that parse an Extension value to instead

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/data/parse_certificate_unittest/extension_critical_0.pem

Issue 2359783003: Convert tests that parse an Extension value to instead (Closed)

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « net/data/parse_certificate_unittest/extension_critical.pem ('k') | net/data/parse_certificate_unittest/extension_critical_3.pem » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 This is a basic constraints extension, where the critical field (BOOLEAN) is 0.	1 This is an unknown extension, where the critical field (BOOLEAN) is 0.

2	2

3 This is not valid because the critical field has a default of FALSE, so under	3 This is not valid because the critical field has a default of FALSE, so under

4 DER-encoding it should be omitted.	4 DER-encoding it should be omitted.

5	5

	6 #-----BEGIN EXTENSION-----

	7 SEQUENCE {

	8 # https://davidben.net/oid

	9 OBJECT_IDENTIFIER { 1.2.840.113554.4.1.72585.0 }

	10 BOOLEAN { `00` }

	11 OCTET_STRING {

	12 SEQUENCE {}

	13 }

	14 }

	15 #-----END EXTENSION-----

6	16

7 $ openssl asn1parse -i < [EXTENSION]	17

8 0:d=0 hl=2 l= 12 cons: SEQUENCE	18 -----BEGIN CERTIFICATE-----

9 2:d=1 hl=2 l= 3 prim: OBJECT :X509v3 Basic Constraints	19 MIICbzCCAdigAwIBAgIJAPuwTC6rEJsMMA0GCSqGSIb3DQEBBQUAMEUxCzAJBgNVBAYTAkFVMRMwEQYD VQQIDApTb21lLVN0YXRlMSEwHwYDVQQKDBhJbnRlcm5ldCBXaWRnaXRzIFB0eSBMdGQwHhcNMTQwNDIz MjA1MDQwWhcNMTcwNDIyMjA1MDQwWjBFMQswCQYDVQQGEwJBVTETMBEGA1UECAwKU29tZS1TdGF0ZTEh MB8GA1UECgwYSW50ZXJuZXQgV2lkZ2l0cyBQdHkgTHRkMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKB gQDYK8imMuRi/03z0K1Zi0WnvfFHvwlYeyK9Na6XJYaUoIDAtB92kWdGMdAQhLciHnAjkXLI6W15OoV3 gA/ElRZ1xUpxTMhjP6PyY5wqT5r6y8FxbiiFKKAnHmUcrgfVW28tQ+0rkLGMryRtrukXOgXBv7gcrmU7 G1jC2a7WqmeI8QIDAQABo2cwZTAdBgNVHQ4EFgQUi3XVrMsIvg4fZbf6Vr5sp3Xaha8wHwYDVR0jBBgw FoAUi3XVrMsIvg4fZbf6Vr5sp3Xaha8wDAYDVR0TBAUwAwEB/zAVBgwqhkiG9xIEAYS3CQABAQAEAjAA MA0GCSqGSIb3DQEBBQUAA4GBADvoeG2V1j1q9xMZLBvCiK4iq/SNMvV8cWfPLdEcwsOH4um+iVzkNKtI kcI/la4rR54leGtPmhCkcv3P9wIMsAoIpFri5XR+ER05YGrJH2nzLmMm3J7va3oK4VRXmKpykXgEfh+P ZU0fCxKsnCQPhBQaVS0fu/CdCbIIXFkyZYAm

10 7:d=1 hl=2 l= 1 prim: BOOLEAN :0	20 -----END CERTIFICATE-----

11 10:d=1 hl=2 l= 2 prim: OCTET STRING [HEX DUMP]:3000

12 -----BEGIN EXTENSION-----

13 MAwGA1UdEwEBAAQCMAA=

14 -----END EXTENSION-----

OLD	NEW