Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2359753003:
Security fix while computing dropdown menu arrow width (Closed)
|
Created:
4 years, 3 months ago by malaykeshav Modified:
4 years, 3 months ago CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSecurity fix while computing dropdown menu arrow width
There is no clean way to set the size for the dropdown menu arrow dynamically
without causing security bugs. Since this is only for tests, using a fixed
width works with _most_ of the test cases while the rest have minor changes
that are acceptable for layout tests.
Context: https://codereview.chromium.org/2340633002
BUG=649095, 649056, 649058, 649132, 640256
COMPONENT=ThemePainterDefault, Menu List Arrow
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Committed: https://crrev.com/63903481bbfd5173416a223bf160fc106f62d1b7
Cr-Commit-Position: refs/heads/master@{#420492}
Patch Set 1 : Security fix while computing dropdown menu arrow width #Patch Set 2 : Updated test expectations #
Messages
Total messages: 34 (25 generated)
Description was changed from ========== Security fix while computing dropdown menu arrow width BUG=649095, 649056, 649058, 649132 COMPONENT=ThemePainterDefault, Menu List Arrow ========== to ========== Security fix while computing dropdown menu arrow width BUG=649095, 649056, 649058, 649132 COMPONENT=ThemePainterDefault, Menu List Arrow CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
Patchset #1 (id:1) has been deleted
The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Security fix while computing dropdown menu arrow width BUG=649095, 649056, 649058, 649132 COMPONENT=ThemePainterDefault, Menu List Arrow CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Security fix while computing dropdown menu arrow width BUG=649095, 649056, 649058, 649132, 640256 COMPONENT=ThemePainterDefault, Menu List Arrow CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Security fix while computing dropdown menu arrow width BUG=649095, 649056, 649058, 649132, 640256 COMPONENT=ThemePainterDefault, Menu List Arrow CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Security fix while computing dropdown menu arrow width There is no clean way to set the size for the dropdown menu arrow icon based on the space available without causing security bugs. Since this is only for tests, using a fixed width works with _most_ of the test cases while the rest have minor changes that are acceptable for layout tests. BUG=649095, 649056, 649058, 649132, 640256 COMPONENT=ThemePainterDefault, Menu List Arrow CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
Description was changed from ========== Security fix while computing dropdown menu arrow width There is no clean way to set the size for the dropdown menu arrow icon based on the space available without causing security bugs. Since this is only for tests, using a fixed width works with _most_ of the test cases while the rest have minor changes that are acceptable for layout tests. BUG=649095, 649056, 649058, 649132, 640256 COMPONENT=ThemePainterDefault, Menu List Arrow CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Security fix while computing dropdown menu arrow width There is no clean way to set the size for the dropdown menu arrow icon based on the space available without causing security bugs. Since this is only for tests, using a fixed width works with _most_ of the test cases while the rest have minor changes that are acceptable for layout tests. BUG=649095, 649056, 649058, 649132, 640256 COMPONENT=ThemePainterDefault, Menu List Arrow CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Description was changed from ========== Security fix while computing dropdown menu arrow width There is no clean way to set the size for the dropdown menu arrow icon based on the space available without causing security bugs. Since this is only for tests, using a fixed width works with _most_ of the test cases while the rest have minor changes that are acceptable for layout tests. BUG=649095, 649056, 649058, 649132, 640256 COMPONENT=ThemePainterDefault, Menu List Arrow CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Security fix while computing dropdown menu arrow width There is no clean way to set the size for the dropdown menu arrow dynamically without causing security bugs. Since this is only for tests, using a fixed width works with _most_ of the test cases while the rest have minor changes that are acceptable for layout tests. Context: https://codereview.chromium.org/2340633002 BUG=649095, 649056, 649058, 649132, 640256 COMPONENT=ThemePainterDefault, Menu List Arrow CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
malaykeshav@chromium.org changed reviewers: + bsep@chromium.org, oshima@chromium.org, wangxianzhu@chromium.org
Description was changed from ========== Security fix while computing dropdown menu arrow width There is no clean way to set the size for the dropdown menu arrow dynamically without causing security bugs. Since this is only for tests, using a fixed width works with _most_ of the test cases while the rest have minor changes that are acceptable for layout tests. Context: https://codereview.chromium.org/2340633002 BUG=649095, 649056, 649058, 649132, 640256 COMPONENT=ThemePainterDefault, Menu List Arrow CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Security fix while computing dropdown menu arrow width There is no clean way to set the size for the dropdown menu arrow dynamically without causing security bugs. Since this is only for tests, using a fixed width works with _most_ of the test cases while the rest have minor changes that are acceptable for layout tests. Context: https://codereview.chromium.org/2340633002 BUG=649095, 649056, 649058, 649132, 640256 COMPONENT=ThemePainterDefault, Menu List Arrow CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
PTAL
lgtm
malaykeshav@chromium.org changed reviewers: + dpranke@chromium.org
You don't need to bother dpranke@ for change of TestExpectations. It can be reviewed by anyone (implied by the '*' in LayoutTests/OWNERS).
lgtm
On 2016/09/22 at 21:19:35, wangxianzhu wrote: > You don't need to bother dpranke@ for change of TestExpectations. It can be reviewed by anyone (implied by the '*' in LayoutTests/OWNERS). Oh! Got it. Thanks :)
The CQ bit was checked by malaykeshav@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
malaykeshav@chromium.org changed reviewers: - dpranke@chromium.org
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Security fix while computing dropdown menu arrow width There is no clean way to set the size for the dropdown menu arrow dynamically without causing security bugs. Since this is only for tests, using a fixed width works with _most_ of the test cases while the rest have minor changes that are acceptable for layout tests. Context: https://codereview.chromium.org/2340633002 BUG=649095, 649056, 649058, 649132, 640256 COMPONENT=ThemePainterDefault, Menu List Arrow CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Security fix while computing dropdown menu arrow width There is no clean way to set the size for the dropdown menu arrow dynamically without causing security bugs. Since this is only for tests, using a fixed width works with _most_ of the test cases while the rest have minor changes that are acceptable for layout tests. Context: https://codereview.chromium.org/2340633002 BUG=649095, 649056, 649058, 649132, 640256 COMPONENT=ThemePainterDefault, Menu List Arrow CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/63903481bbfd5173416a223bf160fc106f62d1b7 Cr-Commit-Position: refs/heads/master@{#420492} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/63903481bbfd5173416a223bf160fc106f62d1b7 Cr-Commit-Position: refs/heads/master@{#420492}
Message was sent while issue was closed.
Patchset #3 (id:60001) has been deleted |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
