Modifies logic for computing drop down menu arrow's dimensions and how it is drawn.

Modifies the logic to compute the dimensions of the drop down menu
arrow that is used in layout tests. This modification allows the
arrow to look the right size in different device scale factors when
using zoom-for-dsf. This is achieved by using a square drop down
arrow instead of a rectangular one. This logic is similar to what
the native theme engine uses.

BUG=640256
COMPONENT=Test Runners, Mock Web Theme Engine
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/b195fcd2e028db859a382323fad3c6910e3205c4
Cr-Commit-Position: refs/heads/master@{#419930}

[malaykeshav, 2016-09-13 22:11:56]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[malaykeshav, 2016-09-13 22:12:26]

malaykeshav@chromium.org changed reviewers:
+ oshima@chromium.org

[commit-bot: I haz the power, 2016-09-13 22:12:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 00:25:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 00:25:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[malaykeshav, 2016-09-16 23:32:15]

Description was changed from

==========
Modifies logic for computing drop down menu arrow's dimensions

Modifies the logic to compute the dimensions of the drop down menu
arrow that is used in layout tests. This modification allows the
arrow to look the right size in different device scale factors when
using zoom-for-dsf.

BUG=640256
COMPONENT=Test Runners, Mock Web Theme Engine
==========

to

==========
Modifies logic for computing drop down menu arrow's dimensions

Modifies the logic to compute the dimensions of the drop down menu
arrow that is used in layout tests. This modification allows the
arrow to look the right size in different device scale factors when
using zoom-for-dsf.

BUG=640256
COMPONENT=Test Runners, Mock Web Theme Engine
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[malaykeshav, 2016-09-16 23:32:58]

Description was changed from

==========
Modifies logic for computing drop down menu arrow's dimensions

Modifies the logic to compute the dimensions of the drop down menu
arrow that is used in layout tests. This modification allows the
arrow to look the right size in different device scale factors when
using zoom-for-dsf.

BUG=640256
COMPONENT=Test Runners, Mock Web Theme Engine
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Modifies the logic to compute the dimensions of the drop down menu
arrow that is used in layout tests. This modification allows the
arrow to look the right size in different device scale factors when
using zoom-for-dsf. This is achieved by using a square drop down
arrow instead of a rectangular one. This logic is similar to what
the native theme engine uses.
    
BUG=640256
COMPONENT=Test Runners, Mock Web Theme Engine
==========

[malaykeshav, 2016-09-16 23:33:18]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 23:33:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oshima, 2016-09-17 01:31:21]

lgtm with nits

https://codereview.chromium.org/2340633002/diff/20001/components/test_runner/...
File components/test_runner/mock_web_theme_engine.cc (right):

https://codereview.chromium.org/2340633002/diff/20001/components/test_runner/...
components/test_runner/mock_web_theme_engine.cc:486:
(extraParams->menuList.arrowSize + 1) / 2)
can  you use std::max ?

https://codereview.chromium.org/2340633002/diff/20001/components/test_runner/...
components/test_runner/mock_web_theme_engine.cc:490: irect.fRight = irect.fLeft
+ extraParams->menuList.arrowSize;
ditto

https://codereview.chromium.org/2340633002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp (right):

https://codereview.chromium.org/2340633002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp:265: int
extraPadding = 3 * box.styleRef().effectiveZoom();
define const for 3 and explain what's in CSS pixel for extra padding.

https://codereview.chromium.org/2340633002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp:271: int arrowSize
= std::min(arrowBoxWidth, rect.height()) - 2 * extraPadding;
80 chars

[commit-bot: I haz the power, 2016-09-17 02:04:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 02:04:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[malaykeshav, 2016-09-19 18:01:56]

Description was changed from

==========
Modifies the logic to compute the dimensions of the drop down menu
arrow that is used in layout tests. This modification allows the
arrow to look the right size in different device scale factors when
using zoom-for-dsf. This is achieved by using a square drop down
arrow instead of a rectangular one. This logic is similar to what
the native theme engine uses.
    
BUG=640256
COMPONENT=Test Runners, Mock Web Theme Engine
==========

to

==========
Modifies the logic to compute the dimensions of the drop down menu
arrow that is used in layout tests. This modification allows the
arrow to look the right size in different device scale factors when
using zoom-for-dsf. This is achieved by using a square drop down
arrow instead of a rectangular one. This logic is similar to what
the native theme engine uses.
    
BUG=640256
COMPONENT=Test Runners, Mock Web Theme Engine
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[malaykeshav, 2016-09-19 18:02:13]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 18:02:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[malaykeshav, 2016-09-19 18:09:27]

Nit changes and rebaseline layout tests

https://codereview.chromium.org/2340633002/diff/20001/components/test_runner/...
File components/test_runner/mock_web_theme_engine.cc (right):

https://codereview.chromium.org/2340633002/diff/20001/components/test_runner/...
components/test_runner/mock_web_theme_engine.cc:486:
(extraParams->menuList.arrowSize + 1) / 2)
On 2016/09/17 at 01:31:21, oshima wrote:
> can  you use std::max ?

Done

https://codereview.chromium.org/2340633002/diff/20001/components/test_runner/...
components/test_runner/mock_web_theme_engine.cc:490: irect.fRight = irect.fLeft
+ extraParams->menuList.arrowSize;
On 2016/09/17 at 01:31:21, oshima wrote:
> ditto

Done

https://codereview.chromium.org/2340633002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp (right):

https://codereview.chromium.org/2340633002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp:265: int
extraPadding = 3 * box.styleRef().effectiveZoom();
On 2016/09/17 at 01:31:21, oshima wrote:
> define const for 3 and explain what's in CSS pixel for extra padding.

Done

https://codereview.chromium.org/2340633002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp:271: int arrowSize
= std::min(arrowBoxWidth, rect.height()) - 2 * extraPadding;
On 2016/09/17 at 01:31:21, oshima wrote:
> 80 chars

This file doesn't follow the 80 char limit. git cl format puts everything in a
single line.

[commit-bot: I haz the power, 2016-09-19 20:10:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 20:10:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[malaykeshav, 2016-09-19 20:27:26]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 20:28:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[malaykeshav, 2016-09-19 21:21:28]

Patchset #3 (id:40001) has been deleted

[malaykeshav, 2016-09-19 22:07:26]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 22:07:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 01:08:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 01:08:50]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[malaykeshav, 2016-09-20 01:15:07]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 01:16:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 02:45:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 02:45:44]

Dry run: This issue passed the CQ dry run.

[malaykeshav, 2016-09-20 18:29:20]

malaykeshav@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[malaykeshav, 2016-09-20 18:29:21]

PTAL

[Xianzhu, 2016-09-20 19:05:13]

lgtm.

[malaykeshav, 2016-09-20 19:06:05]

The CQ bit was checked by malaykeshav@chromium.org

[malaykeshav, 2016-09-20 19:06:05]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2340633002/#ps100001
(title: "Modifies logic for computing drop down menu arrow's dimensions and how
it is drawn.")

[commit-bot: I haz the power, 2016-09-20 19:06:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-09-20 19:07:33]

https://codereview.chromium.org/2340633002/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2340633002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/TestExpectations:366: crbug.com/640256 [ Win ]
fast/text/drawBidiText.html [ NeedsRebaseline ]
Line 366-375 should be removed because they also fail without patch. This seems
related to font configuration on some particular try bots.

[Xianzhu, 2016-09-20 19:07:47]

The CQ bit was unchecked by wangxianzhu@chromium.org

[malaykeshav, 2016-09-20 20:58:21]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 20:59:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[malaykeshav, 2016-09-20 21:17:35]

malaykeshav@chromium.org changed reviewers:
+ dpranke@chromium.org

[malaykeshav, 2016-09-20 21:17:37]

PTAL

[Xianzhu, 2016-09-20 21:35:34]

lgtm.

[commit-bot: I haz the power, 2016-09-20 23:31:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 23:31:25]

Dry run: This issue passed the CQ dry run.

[malaykeshav, 2016-09-21 01:13:11]

friendly ping @dpranke

[Dirk Pranke, 2016-09-21 01:15:18]

lgtm

[malaykeshav, 2016-09-21 01:15:32]

The CQ bit was checked by malaykeshav@chromium.org

[malaykeshav, 2016-09-21 01:15:33]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2340633002/#ps120001
(title: "Modifies logic for computing drop down menu arrow's dimensions and how
it is drawn.")

[commit-bot: I haz the power, 2016-09-21 01:16:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 01:23:18]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-09-21 01:24:58]

Description was changed from

==========
Modifies the logic to compute the dimensions of the drop down menu
arrow that is used in layout tests. This modification allows the
arrow to look the right size in different device scale factors when
using zoom-for-dsf. This is achieved by using a square drop down
arrow instead of a rectangular one. This logic is similar to what
the native theme engine uses.
    
BUG=640256
COMPONENT=Test Runners, Mock Web Theme Engine
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Modifies the logic to compute the dimensions of the drop down menu
arrow that is used in layout tests. This modification allows the
arrow to look the right size in different device scale factors when
using zoom-for-dsf. This is achieved by using a square drop down
arrow instead of a rectangular one. This logic is similar to what
the native theme engine uses.

BUG=640256
COMPONENT=Test Runners, Mock Web Theme Engine
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/b195fcd2e028db859a382323fad3c6910e3205c4
Cr-Commit-Position: refs/heads/master@{#419930}
==========

[commit-bot: I haz the power, 2016-09-21 01:24:59]

Patchset 6 (id:??) landed as
https://crrev.com/b195fcd2e028db859a382323fad3c6910e3205c4
Cr-Commit-Position: refs/heads/master@{#419930}