Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2359733002: Need to consider the need for a soft break even when inserting a forced break. (Closed)

Created:
4 years, 3 months ago by mstensho (USE GERRIT)
Modified:
4 years, 3 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Need to consider the need for a soft break even when inserting a forced break. A forced break will just take us to the next fragmentainer. However, the next fragmentainer may not be tall enough to fit any part of the block we're laying out, which means that we may have to skip to a fragmentainer further ahead - one that is tall enough. This situation may arise in nested multicol, because then we may get inner fragmentainers of variable height. Another reason why we need this is that a forced break on an object is inserted before we apply clearance. After we have applied clearance, we may have ended up at a position where there's not enough space left to fit any part of the block we're laying out. So, again, we may need to skip to the next fragmentainer. BUG=647475 Committed: https://crrev.com/4545acb6ba2bd97d53d4641b90ee1d96fb53f98d Cr-Commit-Position: refs/heads/master@{#420041}

Patch Set 1 #

Messages

Total messages: 13 (7 generated)
mstensho (USE GERRIT)
4 years, 3 months ago (2016-09-21 12:56:46 UTC) #4
eae
OK, LGTM
4 years, 3 months ago (2016-09-21 13:22:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359733002/1
4 years, 3 months ago (2016-09-21 13:44:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 13:49:19 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4545acb6ba2bd97d53d4641b90ee1d96fb53f98d Cr-Commit-Position: refs/heads/master@{#420041}
4 years, 3 months ago (2016-09-21 13:52:16 UTC) #12
mstensho (USE GERRIT)
4 years, 3 months ago (2016-09-22 13:08:22 UTC) #13
Message was sent while issue was closed.
This turned out to also fix bug 604609.

Powered by Google App Engine
This is Rietveld 408576698