third_party/WebKit/Source/core/layout/LayoutBlockFlow.h - Issue 2359733002: Need to consider the need for a soft break even when inserting a forced break.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

Issue 2359733002: Need to consider the need for a soft break even when inserting a forced break. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

index 8ae707a226505b6e80bba45ecea82bc278b541fa..1d32be42a845ccaba479e35fc1f1b6cfd475ca4b 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

@@ -365,8 +365,7 @@ private:

bool positionAndLayoutOnceIfNeeded(LayoutBox& child, LayoutUnit newLogicalTop, BlockChildrenLayoutInfo&);

// Handle breaking policy before the child, and insert a forced break in front of it if needed.

- // Returns true if a forced break was inserted.

- bool insertForcedBreakBeforeChildIfNeeded(LayoutBox& child, BlockChildrenLayoutInfo&);

+ void insertForcedBreakBeforeChildIfNeeded(LayoutBox& child, BlockChildrenLayoutInfo&);

void layoutBlockChild(LayoutBox& child, BlockChildrenLayoutInfo&);

void adjustPositionedBlock(LayoutBox& child, const BlockChildrenLayoutInfo&);