third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp - Issue 2359723003: Implement OffscreenCanvas Accelerated 2D commit()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Issue 2359723003: Implement OffscreenCanvas Accelerated 2D commit() (Closed)

Patch Set: Temporary code for Unaccelerated case Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/test/data/gpu/pixel_acceleratedOffscreen2d_commit_main.html ('K') | « third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp ('k') | third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcher.h » ('j') | third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

index 70d9cf301bc3dc51a20b8a18a76ffbd420f4fdeb..f08f4ea5fbf4ad64a497213d0f6c17c26ffb5e29 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

@@ -665,7 +665,7 @@ void WebGLRenderingContextBase::commit(ExceptionState& exceptionState)

if (!drawingBuffer())

return;

// TODO(crbug.com/646864): Make commit() work correctly with { preserveDrawingBuffer : true }.

- getOffscreenCanvas()->getOrCreateFrameDispatcher()->dispatchFrame(std::move(drawingBuffer()->transferToStaticBitmapImage()));

+ getOffscreenCanvas()->getOrCreateFrameDispatcher()->dispatchFrame(std::move(drawingBuffer()->transferToStaticBitmapImage()), this->isAccelerated());

xlai (Olivia) 2016/09/22 16:12:24 In WebGL, this->isAccelerated() is confirmed to re

}

PassRefPtr<Image> WebGLRenderingContextBase::getImage(AccelerationHint hint, SnapshotReason reason) const