Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 23597024: Revert 222257 "Revert 222235 ""Redirecting URLs to Packaged Apps..." (Closed)

Created:
7 years, 3 months ago by SteveT
Modified:
7 years, 3 months ago
Reviewers:
SteveT
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 222257 "Revert 222235 ""Redirecting URLs to Packaged Apps..." Reason for revert: The first revert didn't actually fix the issues with the Chrome Frame net test failures, so I'm putting the patch back in. > Revert 222235 ""Redirecting URLs to Packaged Apps" implementatio..." > > > "Redirecting URLs to Packaged Apps" implementation: revised > > > > Design proposal: https://docs.google.com/document/d/1r-RoOv2URfZBYrT_B6notQ6MeMqZRd1EP1AITuzJCAc/edit?usp=sharing > > > > * Support for url_handlers in manifest > > * New kind of onLaunched event with navigation info in launch data > > * Intercept/redirect top-level browser-initiated navigations (bookmarks, omnibox, etc.) > > * Intercept/redirect top-frame navigations in tabs and app windows. > > > > This is a rework of https://codereview.chromium.org/22944002/. > > > > BUG=111422 > > > > Review URL: https://chromiumcodereview.appspot.com/23847004 > > Reason for revert: > This is the most likely cause of the chrome_frame_net_tests failures (various tests), since no other changes in the blamelist were touching URLRequest bits. > > First failure here: http://build.chromium.org/p/chromium.win/builders/Chrome%20Frame%20Tests%20%28ie6%29/builds/46826 > > TBR=sergeygs@chromium.org > > Review URL: https://codereview.chromium.org/23600025 TBR=stevet@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222258

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, --16 lines) Patch
M trunk/src/apps/launcher.h View 3 chunks +17 lines, -4 lines 0 comments Download
M trunk/src/apps/launcher.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/apps/app_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/apps/app_browsertest_util.h View 2 chunks +4 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/apps/app_browsertest_util.cc View 1 chunk +10 lines, -3 lines 0 comments Download
A + trunk/src/chrome/browser/apps/app_url_redirector.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/apps/app_url_redirector.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/apps/app_url_redirector_browsertest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/app_runtime/app_runtime_api.h View 2 chunks +15 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/app_runtime/app_runtime_api.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 4 chunks +15 lines, -5 lines 0 comments Download
M trunk/src/chrome/chrome_browser_extensions.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/chrome_common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/common/extensions/api/_manifest_features.json View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/chrome/common/extensions/api/app_runtime.idl View 1 chunk +16 lines, -2 lines 0 comments Download
A + trunk/src/chrome/common/extensions/api/url_handlers/url_handlers_parser.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/common/extensions/api/url_handlers/url_handlers_parser.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/chrome/common/extensions/chrome_manifest_handlers.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/common/extensions/extension_manifest_constants.h View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/chrome/common/extensions/extension_manifest_constants.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M trunk/src/chrome/renderer/resources/extensions/app_runtime_custom_bindings.js View 2 chunks +12 lines, -5 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/common/mismatching_target.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/common/target.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/handlers/navigate_webview_to_url/main.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/handlers/navigate_webview_to_url/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/handlers/navigate_webview_to_url/test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/handlers/simple/main.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/handlers/simple/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/handlers/simple/test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/handlers/steal_xhr_target/main.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/handlers/steal_xhr_target/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/handlers/steal_xhr_target/test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/launchers/call_mismatching_window_open/main.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/launchers/call_mismatching_window_open/main.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/launchers/call_mismatching_window_open/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/launchers/call_mismatching_window_open/test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/launchers/call_window_open/main.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/launchers/call_window_open/main.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/launchers/call_window_open/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/launchers/call_window_open/test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/launchers/click_blank_link/main.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/launchers/click_blank_link/main.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/launchers/click_blank_link/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/launchers/click_blank_link/test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/launchers/click_mismatching_blank_link/main.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/launchers/click_mismatching_blank_link/main.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/launchers/click_mismatching_blank_link/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/launchers/click_mismatching_blank_link/test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/launching_pages/call_window_open.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/launching_pages/click_blank_link.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/launching_pages/click_link.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/launching_pages/click_mismatching_link.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/launching_pages/navigate.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/xhr_downloader/download.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/xhr_downloader/main.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/extensions/platform_apps/url_handlers/xhr_downloader/target.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/extensions/common/manifest_constants.h View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/extensions/common/manifest_constants.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
SteveT
7 years, 3 months ago (2013-09-10 15:30:22 UTC) #1
SteveT
7 years, 3 months ago (2013-09-10 15:32:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r222258.

Powered by Google App Engine
This is Rietveld 408576698