Revert 222235 ""Redirecting URLs to Packaged Apps" implementatio..."

Revert 222235 ""Redirecting URLs to Packaged Apps" implementatio..."

> "Redirecting URLs to Packaged Apps" implementation: revised
> 
> Design proposal: https://docs.google.com/document/d/1r-RoOv2URfZBYrT_B6notQ6MeMqZRd1EP1AITuzJCAc/edit?usp=sharing
> 
> * Support for url_handlers in manifest
> * New kind of onLaunched event with navigation info in launch data
> * Intercept/redirect top-level browser-initiated navigations (bookmarks, omnibox, etc.)
> * Intercept/redirect top-frame navigations in tabs and app windows. 
> 
> This is a rework of https://codereview.chromium.org/22944002/.
> 
> BUG=111422
> 
> Review URL: https://chromiumcodereview.appspot.com/23847004

Reason for revert:
This is the most likely cause of the chrome_frame_net_tests failures (various tests), since no other changes in the blamelist were touching URLRequest bits.

First failure here: http://build.chromium.org/p/chromium.win/builders/Chrome%20Frame%20Tests%20%28ie6%29/builds/46826

TBR=sergeygs@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222257

[SteveT, 2013-09-10 13:19:34]

Committed patchset #1 manually as r222257.

[sergeygs, 2013-09-10 16:26:52]

On 2013/09/10 13:19:34, SteveT wrote:
> Committed patchset #1 manually as r222257.

The link to the failure is broken. Can you post a correct one?

[Steve, 2013-09-10 16:28:23]

The first failure:
http://build.chromium.org/p/chromium.win/builders/Chrome%20Frame%20Tests%20%2...

A bot with all the failures:
http://build.chromium.org/p/chromium.win/builders/Chrome%20Frame%20Tests%20(ie6)


On Tue, Sep 10, 2013 at 12:26 PM, <sergeygs@chromium.org> wrote:

> On 2013/09/10 13:19:34, SteveT wrote:
>
>> Committed patchset #1 manually as r222257.
>>
>
> The link to the failure is broken. Can you post a correct one?
>
>
https://codereview.chromium.**org/23600025/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Steve, 2013-09-10 16:29:07]

And FYI I un-reverted your patch as it didn't not seem to fix the issue.

So I suspect you're off the hook and something else funny happened in that
blamelist.


On Tue, Sep 10, 2013 at 12:28 PM, Steve Truong <stevet@google.com> wrote:

> The first failure:
>
http://build.chromium.org/p/chromium.win/builders/Chrome%20Frame%20Tests%20%2...
>
> A bot with all the failures:
>
http://build.chromium.org/p/chromium.win/builders/Chrome%20Frame%20Tests%20(ie6)
>
>
> On Tue, Sep 10, 2013 at 12:26 PM, <sergeygs@chromium.org> wrote:
>
>> On 2013/09/10 13:19:34, SteveT wrote:
>>
>>> Committed patchset #1 manually as r222257.
>>>
>>
>> The link to the failure is broken. Can you post a correct one?
>>
>>
https://codereview.chromium.**org/23600025/<https://codereview.chromium.org/2...
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sergeygs1, 2013-09-10 16:34:47]

Yes, thanks, I have already noticed the revert of the revert.


On Tue, Sep 10, 2013 at 9:28 AM, Steve Truong <stevet@google.com> wrote:

> And FYI I un-reverted your patch as it didn't not seem to fix the issue.
>
> So I suspect you're off the hook and something else funny happened in that
> blamelist.
>
>
> On Tue, Sep 10, 2013 at 12:28 PM, Steve Truong <stevet@google.com> wrote:
>
>> The first failure:
>>
http://build.chromium.org/p/chromium.win/builders/Chrome%20Frame%20Tests%20%2...
>>
>> A bot with all the failures:
>>
http://build.chromium.org/p/chromium.win/builders/Chrome%20Frame%20Tests%20(ie6)
>>
>>
>> On Tue, Sep 10, 2013 at 12:26 PM, <sergeygs@chromium.org> wrote:
>>
>>> On 2013/09/10 13:19:34, SteveT wrote:
>>>
>>>> Committed patchset #1 manually as r222257.
>>>>
>>>
>>> The link to the failure is broken. Can you post a correct one?
>>>
>>>
https://codereview.chromium.**org/23600025/<https://codereview.chromium.org/2...
>>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.