Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2359503002: Let TRACE_EVENT_XXX_WITH_TIMESTAMP accept TimeTicks instead of int64_t (Closed)

Created:
4 years, 3 months ago by Xianzhu
Modified:
4 years, 3 months ago
CC:
blink-reviews, blink-reviews-events_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, jam, loading-reviews_chromium.org, mlamouri+watch-content_chromium.org, mmenke, nasko+codewatch_chromium.org, pfeldman, piman+watch_chromium.org, Randy Smith (Not in Mondays), scheduler-bugs_chromium.org, tdresser+watch_chromium.org, tracing+reviews_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let TRACE_EVENT_XXX_WITH_TIMESTAMP accept TimeTicks instead of int64_t This can prevent errors of passing timestamp with wrong unit, especially in blink where previously double timestamp in seconds were used. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation R=oystein TBR=passive changes in other directories Committed: https://crrev.com/407f571e3dd1cd44a8501710d247ebe041d4cdcf Cr-Commit-Position: refs/heads/master@{#420154}

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : - #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -40 lines) Patch
M base/android/early_trace_event_binding.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M base/trace_event/common/trace_event_common.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_event.h View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M base/trace_event/trace_event_unittest.cc View 1 5 chunks +11 lines, -10 lines 0 comments Download
M components/startup_metric_utils/browser/startup_metric_utils.cc View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/devtools/devtools_frame_trace_recorder.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigation_handle_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigation_request.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/navigation_url_loader_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/devtools/v8_sampling_profiler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M gpu/command_buffer/service/gpu_tracer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/TraceEvent.h View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/idle_helper.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/events/latency_info.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 35 (27 generated)
Xianzhu
4 years, 3 months ago (2016-09-21 04:54:42 UTC) #18
oystein (OOO til 10th of July)
Sweet! Tracing lgtm!
4 years, 3 months ago (2016-09-21 19:50:32 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359503002/60001
4 years, 3 months ago (2016-09-21 19:59:57 UTC) #24
charliea (OOO until 10-5)
Thank you!!
4 years, 3 months ago (2016-09-21 20:02:47 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_site_isolation\ on master.tryserver.chromium.linux (JOB_FAILED, no build URL)
4 years, 3 months ago (2016-09-21 20:02:58 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359503002/60001
4 years, 3 months ago (2016-09-21 20:30:40 UTC) #31
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-21 20:37:13 UTC) #33
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 20:39:05 UTC) #35
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/407f571e3dd1cd44a8501710d247ebe041d4cdcf
Cr-Commit-Position: refs/heads/master@{#420154}

Powered by Google App Engine
This is Rietveld 408576698