content/renderer/devtools/v8_sampling_profiler.cc - Issue 2359503002: Let TRACE_EVENT_XXX_WITH_TIMESTAMP accept TimeTicks instead of int64_t

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/devtools/v8_sampling_profiler.cc

Issue 2359503002: Let TRACE_EVENT_XXX_WITH_TIMESTAMP accept TimeTicks instead of int64_t (Closed)

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/devtools/v8_sampling_profiler.cc

diff --git a/content/renderer/devtools/v8_sampling_profiler.cc b/content/renderer/devtools/v8_sampling_profiler.cc

index baf2e50b3721fe0a8863f244ac2eb99476ee3568..9c0acd628dbe20ade52e3b72e110d40bce1d939e 100644

--- a/content/renderer/devtools/v8_sampling_profiler.cc

+++ b/content/renderer/devtools/v8_sampling_profiler.cc

@@ -303,8 +303,7 @@ void Sampler::InjectPendingEvents() {

TRACE_EVENT_SAMPLE_WITH_TID_AND_TIMESTAMP1(

TRACE_DISABLED_BY_DEFAULT("v8.cpu_profile"), "V8Sample",

platform_data_.thread_id(),

- (record->timestamp() - base::TimeTicks()).InMicroseconds(), "data",

- record->ToTraceFormat());

+ record->timestamp(), "data", record->ToTraceFormat());

samples_data_->Remove();

record = samples_data_->Peek();

base::subtle::NoBarrier_AtomicIncrement(&samples_count_, 1);