Fix some GPU image filter code to preserve precision and color space

Fix some GPU image filter code to preserve precision and color space

On the pure-GPU path, we just have an SkSpecialImage (that's definitely
texture backed), and we need a renderable config for the draw context we
make. Added a helper function to pick - this is basically the high
precision analog of what we were doing before (always using 8888).

The assert that I added catches many other problems in image filter code,
but those fixes are coming in subsequent CLs.

12 GMs render correctly (or more correctly) in gpusrgb and gpuf16
configs. In most cases, they were drawing previously nothing.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2359443003

Committed: https://skia.googlesource.com/skia/+/2695eaa41fbd208dcee9e134e180c6609856f0ac

[Brian Osman, 2016-09-20 20:55:07]

Description was changed from

==========
Fix a bunch of image filter code to preserve precision and color space

On the pure-GPU path, we just have an SkSpecialImage (that's definitely
texture backed), and we need a renderable config for the draw context we
make. Added a helper function to pick - this is basically the high
precision analog of what we were doing before (always using 8888).

The assert that I added catches many other problems in image filter code,
but those fixes are coming in subsequent CLs.

12 GMs render correctly (or more correctly) in gpusrgb and gpuf16
configs. In most cases, they were drawing previously nothing.

BUG=skia:
==========

to

==========
Fix a bunch of image filter code to preserve precision and color space

On the pure-GPU path, we just have an SkSpecialImage (that's definitely
texture backed), and we need a renderable config for the draw context we
make. Added a helper function to pick - this is basically the high
precision analog of what we were doing before (always using 8888).

The assert that I added catches many other problems in image filter code,
but those fixes are coming in subsequent CLs.

12 GMs render correctly (or more correctly) in gpusrgb and gpuf16
configs. In most cases, they were drawing previously nothing.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2359443003
==========

[Brian Osman, 2016-09-20 20:56:26]

Description was changed from

==========
Fix a bunch of image filter code to preserve precision and color space

On the pure-GPU path, we just have an SkSpecialImage (that's definitely
texture backed), and we need a renderable config for the draw context we
make. Added a helper function to pick - this is basically the high
precision analog of what we were doing before (always using 8888).

The assert that I added catches many other problems in image filter code,
but those fixes are coming in subsequent CLs.

12 GMs render correctly (or more correctly) in gpusrgb and gpuf16
configs. In most cases, they were drawing previously nothing.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2359443003
==========

to

==========
Fix some GPU image filter code to preserve precision and color space

On the pure-GPU path, we just have an SkSpecialImage (that's definitely
texture backed), and we need a renderable config for the draw context we
make. Added a helper function to pick - this is basically the high
precision analog of what we were doing before (always using 8888).

The assert that I added catches many other problems in image filter code,
but those fixes are coming in subsequent CLs.

12 GMs render correctly (or more correctly) in gpusrgb and gpuf16
configs. In most cases, they were drawing previously nothing.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2359443003
==========

[Brian Osman, 2016-09-20 20:57:42]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[Brian Osman, 2016-09-20 20:57:48]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 20:57:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 21:19:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 21:19:43]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-09-21 13:28:13]

lgtm

[Brian Osman, 2016-09-21 13:43:49]

The CQ bit was checked by brianosman@google.com

[commit-bot: I haz the power, 2016-09-21 13:43:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robertphillips, 2016-09-21 13:44:10]

lgtm

https://codereview.chromium.org/2359443003/diff/1/src/gpu/SkGrPriv.h
File src/gpu/SkGrPriv.h (right):

https://codereview.chromium.org/2359443003/diff/1/src/gpu/SkGrPriv.h#newcode110
src/gpu/SkGrPriv.h:110: we want to preserve the color space of that source. This
picks an appropriate format to use. */
Should this take a const SkColorSpace* ?

[commit-bot: I haz the power, 2016-09-21 13:45:11]

Description was changed from

==========
Fix some GPU image filter code to preserve precision and color space

On the pure-GPU path, we just have an SkSpecialImage (that's definitely
texture backed), and we need a renderable config for the draw context we
make. Added a helper function to pick - this is basically the high
precision analog of what we were doing before (always using 8888).

The assert that I added catches many other problems in image filter code,
but those fixes are coming in subsequent CLs.

12 GMs render correctly (or more correctly) in gpusrgb and gpuf16
configs. In most cases, they were drawing previously nothing.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2359443003
==========

to

==========
Fix some GPU image filter code to preserve precision and color space

On the pure-GPU path, we just have an SkSpecialImage (that's definitely
texture backed), and we need a renderable config for the draw context we
make. Added a helper function to pick - this is basically the high
precision analog of what we were doing before (always using 8888).

The assert that I added catches many other problems in image filter code,
but those fixes are coming in subsequent CLs.

12 GMs render correctly (or more correctly) in gpusrgb and gpuf16
configs. In most cases, they were drawing previously nothing.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2359443003

Committed:
https://skia.googlesource.com/skia/+/2695eaa41fbd208dcee9e134e180c6609856f0ac
==========

[commit-bot: I haz the power, 2016-09-21 13:45:12]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2695eaa41fbd208dcee9e134e180c6609856f0ac

[Brian Osman, 2016-09-21 13:47:35]

On 2016/09/21 13:44:10, robertphillips wrote:
> lgtm
> 
> https://codereview.chromium.org/2359443003/diff/1/src/gpu/SkGrPriv.h
> File src/gpu/SkGrPriv.h (right):
> 
>
https://codereview.chromium.org/2359443003/diff/1/src/gpu/SkGrPriv.h#newcode110
> src/gpu/SkGrPriv.h:110: we want to preserve the color space of that source.
This
> picks an appropriate format to use. */
> Should this take a const SkColorSpace* ?

Yeah. I'll fold that fix into the dependent change.