Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 2359423002: arc: Use high-resolution icon for Play Store default item for scale >= 1.5f. (Closed)

Created:
4 years, 3 months ago by hshi1
Modified:
4 years, 3 months ago
Reviewers:
xiyuan, stevenjb, khmel
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, Matt Giuca
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

arc: Use high-resolution icon for Play Store default item for scale >= 1.5f. There was previously a typo in this line. We should pick the high-resolution icon when scale >= 1.5f and the low-resolution icon otherwise. BUG=648998 BUG=b/31596656 TEST=samus verify icon is high resolution in app list before arc opt-in TBR=xiyuan Review-Url: https://codereview.chromium.org/2360873004 Cr-Commit-Position: refs/heads/master@{#420572} (cherry picked from commit 74afbf8b83b12fb72e76a7bc676555c3956fdfa8) NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/app_list/arc/arc_app_icon.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
hshi1
4 years, 3 months ago (2016-09-23 04:26:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359423002/1
4 years, 3 months ago (2016-09-23 13:52:54 UTC) #4
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 3 months ago (2016-09-23 13:52:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359423002/1
4 years, 3 months ago (2016-09-23 13:53:55 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 13:54:52 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698