arc: Use high-resolution icon for Play Store default item for scale >= 1.5f.

arc: Use high-resolution icon for Play Store default item for scale >= 1.5f.

There was previously a typo in this line. We should pick the high-resolution
icon when scale >= 1.5f and the low-resolution icon otherwise.

BUG=648998
BUG=b/31596656
TEST=samus verify icon is high resolution in app list before arc opt-in
TBR=xiyuan

Committed: https://crrev.com/74afbf8b83b12fb72e76a7bc676555c3956fdfa8
Cr-Commit-Position: refs/heads/master@{#420572}

[hshi1, 2016-09-23 01:37:41]

hshi@chromium.org changed reviewers:
+ khmel@chromium.org, xiyuan@chromium.org

[hshi1, 2016-09-23 01:37:42]

PTAL

[hshi1, 2016-09-23 01:37:48]

The CQ bit was checked by hshi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 01:38:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hshi1, 2016-09-23 01:41:35]

Description was changed from

==========
arc: Use high-resolution icon for Play Store default item for scale > 1.5f.

There was previously a typo in this line. We should pick the high-resolution
icon when scale > 1.5f and the low-resolution icon otherwise.

BUG=b/31596656
TEST=samus verify icon is high resolution in app list before arc opt-in
==========

to

==========
arc: Use high-resolution icon for Play Store default item for scale > 1.5f.

There was previously a typo in this line. We should pick the high-resolution
icon when scale > 1.5f and the low-resolution icon otherwise.

BUG=648998
BUG=b/31596656
TEST=samus verify icon is high resolution in app list before arc opt-in
==========

[hshi1, 2016-09-23 01:43:06]

Description was changed from

==========
arc: Use high-resolution icon for Play Store default item for scale > 1.5f.

There was previously a typo in this line. We should pick the high-resolution
icon when scale > 1.5f and the low-resolution icon otherwise.

BUG=648998
BUG=b/31596656
TEST=samus verify icon is high resolution in app list before arc opt-in
==========

to

==========
arc: Use high-resolution icon for Play Store default item for scale >= 1.5f.

There was previously a typo in this line. We should pick the high-resolution
icon when scale >= 1.5f and the low-resolution icon otherwise.

BUG=648998
BUG=b/31596656
TEST=samus verify icon is high resolution in app list before arc opt-in
==========

[khmel, 2016-09-23 01:44:45]

https://codereview.chromium.org/2360873004/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/arc/arc_app_icon.cc (right):

https://codereview.chromium.org/2360873004/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/arc/arc_app_icon.cc:91: IDR_ARC_SUPPORT_ICON_96 :
IDR_ARC_SUPPORT_ICON_48;
could you please retest that it works as expected. I pained one icon one color
and another icon different color and made sure that app list contains right one.

I probably formatted the code and made that typo but not sure 100%

Thanks

[hshi1, 2016-09-23 01:47:50]

https://codereview.chromium.org/2360873004/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/arc/arc_app_icon.cc (right):

https://codereview.chromium.org/2360873004/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/arc/arc_app_icon.cc:91: IDR_ARC_SUPPORT_ICON_96 :
IDR_ARC_SUPPORT_ICON_48;
On 2016/09/23 01:44:45, khmel wrote:
> could you please retest that it works as expected. I pained one icon one color
> and another icon different color and made sure that app list contains right
one.
> 
> I probably formatted the code and made that typo but not sure 100%
> 
> Thanks

Yes I did just retest this (I'm using a paint tool to modify one of the PNGs). 

Note that you must test this BEFORE the Play Store opt-in flow. Because after
that the icon is not the one shipped with Chrome but the actual play store icon.

[khmel, 2016-09-23 01:48:54]

https://codereview.chromium.org/2360873004/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/arc/arc_app_icon.cc (right):

https://codereview.chromium.org/2360873004/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/arc/arc_app_icon.cc:91: IDR_ARC_SUPPORT_ICON_96 :
IDR_ARC_SUPPORT_ICON_48;
On 2016/09/23 01:47:50, hshi1 wrote:
> On 2016/09/23 01:44:45, khmel wrote:
> > could you please retest that it works as expected. I pained one icon one
color
> > and another icon different color and made sure that app list contains right
> one.
> > 
> > I probably formatted the code and made that typo but not sure 100%
> > 
> > Thanks
> 
> Yes I did just retest this (I'm using a paint tool to modify one of the PNGs).

> 
> Note that you must test this BEFORE the Play Store opt-in flow. Because after
> that the icon is not the one shipped with Chrome but the actual play store
icon.

Thanks, lgtm

[commit-bot: I haz the power, 2016-09-23 02:03:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 02:03:13]

Dry run: This issue passed the CQ dry run.

[hshi1, 2016-09-23 02:04:23]

The CQ bit was checked by hshi@chromium.org

[commit-bot: I haz the power, 2016-09-23 02:04:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hshi1, 2016-09-23 02:10:33]

Oops. Presubmit failed.

xiyuan@ - sorry, need OWNER lgtm. thanks!

[commit-bot: I haz the power, 2016-09-23 02:13:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 02:13:57]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hshi1, 2016-09-23 03:53:42]

Description was changed from

==========
arc: Use high-resolution icon for Play Store default item for scale >= 1.5f.

There was previously a typo in this line. We should pick the high-resolution
icon when scale >= 1.5f and the low-resolution icon otherwise.

BUG=648998
BUG=b/31596656
TEST=samus verify icon is high resolution in app list before arc opt-in
==========

to

==========
arc: Use high-resolution icon for Play Store default item for scale >= 1.5f.

There was previously a typo in this line. We should pick the high-resolution
icon when scale >= 1.5f and the low-resolution icon otherwise.

BUG=648998
BUG=b/31596656
TEST=samus verify icon is high resolution in app list before arc opt-in
TBR=xiyuan
==========

[hshi1, 2016-09-23 03:53:49]

The CQ bit was checked by hshi@chromium.org

[commit-bot: I haz the power, 2016-09-23 03:54:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 03:59:09]

Description was changed from

==========
arc: Use high-resolution icon for Play Store default item for scale >= 1.5f.

There was previously a typo in this line. We should pick the high-resolution
icon when scale >= 1.5f and the low-resolution icon otherwise.

BUG=648998
BUG=b/31596656
TEST=samus verify icon is high resolution in app list before arc opt-in
TBR=xiyuan
==========

to

==========
arc: Use high-resolution icon for Play Store default item for scale >= 1.5f.

There was previously a typo in this line. We should pick the high-resolution
icon when scale >= 1.5f and the low-resolution icon otherwise.

BUG=648998
BUG=b/31596656
TEST=samus verify icon is high resolution in app list before arc opt-in
TBR=xiyuan
==========

[commit-bot: I haz the power, 2016-09-23 03:59:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-23 04:00:17]

Description was changed from

==========
arc: Use high-resolution icon for Play Store default item for scale >= 1.5f.

There was previously a typo in this line. We should pick the high-resolution
icon when scale >= 1.5f and the low-resolution icon otherwise.

BUG=648998
BUG=b/31596656
TEST=samus verify icon is high resolution in app list before arc opt-in
TBR=xiyuan
==========

to

==========
arc: Use high-resolution icon for Play Store default item for scale >= 1.5f.

There was previously a typo in this line. We should pick the high-resolution
icon when scale >= 1.5f and the low-resolution icon otherwise.

BUG=648998
BUG=b/31596656
TEST=samus verify icon is high resolution in app list before arc opt-in
TBR=xiyuan

Committed: https://crrev.com/74afbf8b83b12fb72e76a7bc676555c3956fdfa8
Cr-Commit-Position: refs/heads/master@{#420572}
==========

[commit-bot: I haz the power, 2016-09-23 04:00:18]

Patchset 1 (id:??) landed as
https://crrev.com/74afbf8b83b12fb72e76a7bc676555c3956fdfa8
Cr-Commit-Position: refs/heads/master@{#420572}