Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 235913011: DevTools: fix rendering of markers on flame chart (Closed)

Created:
6 years, 8 months ago by caseq
Modified:
6 years, 8 months ago
Reviewers:
pfeldman, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: fix rendering of markers on flame chart Under certain conditions, we used to have a cross-like image taking the entire canvas instead of several rows of markers. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171483

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/devtools/front_end/FlameChart.js View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
caseq
6 years, 8 months ago (2014-04-14 16:00:22 UTC) #1
pfeldman
lgtm
6 years, 8 months ago (2014-04-14 16:07:09 UTC) #2
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 8 months ago (2014-04-14 16:08:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/235913011/20001
6 years, 8 months ago (2014-04-14 16:08:12 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 17:09:38 UTC) #5
Message was sent while issue was closed.
Change committed as 171483

Powered by Google App Engine
This is Rietveld 408576698