Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2051)

Unified Diff: Source/devtools/front_end/FlameChart.js

Issue 235913011: DevTools: fix rendering of markers on flame chart (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/FlameChart.js
diff --git a/Source/devtools/front_end/FlameChart.js b/Source/devtools/front_end/FlameChart.js
index 6fbdcf63c199ed79bcb5e452d7f7ca9740d42dfd..533903da69a2a19d05ab1320b50e96cd1a1ebf5d 100644
--- a/Source/devtools/front_end/FlameChart.js
+++ b/Source/devtools/front_end/FlameChart.js
@@ -625,6 +625,7 @@ WebInspector.FlameChart.prototype = {
var barLevel = entryLevels[entryIndex];
var barY = this._levelToHeight(barLevel);
if (isNaN(entryTotalTimes[entryIndex])) {
+ context.moveTo(barX + this._markerRadius, barY + barHeight / 2);
context.arc(barX, barY + barHeight / 2, this._markerRadius, 0, Math.PI * 2);
markerIndices[nextMarkerIndex++] = entryIndex;
} else {
@@ -637,16 +638,17 @@ WebInspector.FlameChart.prototype = {
}
context.strokeStyle = "rgb(0, 0, 0)";
+ context.beginPath();
for (var m = 0; m < nextMarkerIndex; ++m) {
var entryIndex = markerIndices[m];
var entryOffset = entryOffsets[entryIndex];
var barX = this._offsetToPosition(entryOffset);
var barLevel = entryLevels[entryIndex];
var barY = this._levelToHeight(barLevel);
- context.beginPath();
+ context.moveTo(barX + this._markerRadius, barY + barHeight / 2);
context.arc(barX, barY + barHeight / 2, this._markerRadius, 0, Math.PI * 2);
- context.stroke();
}
+ context.stroke();
context.textBaseline = "alphabetic";
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698