Source/core/page/DOMWindow.cpp - Issue 23591059: Use null Strings for default values of MessageEvent properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/DOMWindow.cpp

Issue 23591059: Use null Strings for default values of MessageEvent properties (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/DOMWindow.cpp

diff --git a/Source/core/page/DOMWindow.cpp b/Source/core/page/DOMWindow.cpp

index abe3beef55b4eca7afbfd16772a16b0d2e3bfea0..1e59d664f7335260683f219c11dfb3eef9141fbb 100644

--- a/Source/core/page/DOMWindow.cpp

+++ b/Source/core/page/DOMWindow.cpp

@@ -119,7 +119,7 @@ public:

PassRefPtr<MessageEvent> event(ScriptExecutionContext* context)

{

OwnPtr<MessagePortArray> messagePorts = MessagePort::entanglePorts(*context, m_channels.release());

- return MessageEvent::create(messagePorts.release(), m_message, m_origin, "", m_source);

+ return MessageEvent::create(messagePorts.release(), m_message, m_origin, String(), m_source);

}

SecurityOrigin* targetOrigin() const { return m_targetOrigin.get(); }

ScriptCallStack* stackTrace() const { return m_stackTrace.get(); }