Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Side by Side Diff: Source/core/page/DOMWindow.cpp

Issue 23591059: Use null Strings for default values of MessageEvent properties (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 , m_source(source) 112 , m_source(source)
113 , m_channels(channels) 113 , m_channels(channels)
114 , m_targetOrigin(targetOrigin) 114 , m_targetOrigin(targetOrigin)
115 , m_stackTrace(stackTrace) 115 , m_stackTrace(stackTrace)
116 { 116 {
117 } 117 }
118 118
119 PassRefPtr<MessageEvent> event(ScriptExecutionContext* context) 119 PassRefPtr<MessageEvent> event(ScriptExecutionContext* context)
120 { 120 {
121 OwnPtr<MessagePortArray> messagePorts = MessagePort::entanglePorts(*cont ext, m_channels.release()); 121 OwnPtr<MessagePortArray> messagePorts = MessagePort::entanglePorts(*cont ext, m_channels.release());
122 return MessageEvent::create(messagePorts.release(), m_message, m_origin, "", m_source); 122 return MessageEvent::create(messagePorts.release(), m_message, m_origin, String(), m_source);
123 } 123 }
124 SecurityOrigin* targetOrigin() const { return m_targetOrigin.get(); } 124 SecurityOrigin* targetOrigin() const { return m_targetOrigin.get(); }
125 ScriptCallStack* stackTrace() const { return m_stackTrace.get(); } 125 ScriptCallStack* stackTrace() const { return m_stackTrace.get(); }
126 126
127 private: 127 private:
128 virtual void fired() 128 virtual void fired()
129 { 129 {
130 m_window->postMessageTimerFired(adoptPtr(this)); 130 m_window->postMessageTimerFired(adoptPtr(this));
131 // This object is deleted now. 131 // This object is deleted now.
132 } 132 }
(...skipping 1627 matching lines...) Expand 10 before | Expand all | Expand 10 after
1760 return static_cast<DOMWindowLifecycleNotifier*>(LifecycleContext::lifecycleN otifier()); 1760 return static_cast<DOMWindowLifecycleNotifier*>(LifecycleContext::lifecycleN otifier());
1761 } 1761 }
1762 1762
1763 PassOwnPtr<LifecycleNotifier> DOMWindow::createLifecycleNotifier() 1763 PassOwnPtr<LifecycleNotifier> DOMWindow::createLifecycleNotifier()
1764 { 1764 {
1765 return DOMWindowLifecycleNotifier::create(this); 1765 return DOMWindowLifecycleNotifier::create(this);
1766 } 1766 }
1767 1767
1768 1768
1769 } // namespace WebCore 1769 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698