Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 23591022: Make image set insertion work in more cases (Closed)

Created:
7 years, 3 months ago by Rafał Chłodnicki
Modified:
7 years, 3 months ago
Reviewers:
flackr
CC:
grit-developer_googlegroups.com
Visibility:
Public.

Description

Make image set insertion work in more cases In case there was a background with multiple layers (background: url(...), url(...);), code would just replace first URL occurrence with -webkit-image-set rule. Handles multiple layers in case there are only url() functions. Still won't work if value contains more values than just url()s. Additionally, use \s for matching white space, so that Windows line endings are also handled. And allow line breaks between 'content|background[...]:' and the following value. Code would previously stop matching if there was a line break between the colon and the value.

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -10 lines) Patch
M grit/gather/chrome_html.py View 5 chunks +39 lines, -10 lines 0 comments Download
M grit/gather/chrome_html_unittest.py View 1 1 chunk +115 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Rafał Chłodnicki
7 years, 3 months ago (2013-09-02 20:56:53 UTC) #1
Joao da Silva
Rob is the right reviewer for this.
7 years, 3 months ago (2013-09-03 08:20:23 UTC) #2
Joao da Silva
7 years, 3 months ago (2013-09-03 08:20:38 UTC) #3
flackr
LGTM
7 years, 3 months ago (2013-09-03 15:37:30 UTC) #4
Rafał Chłodnicki
On 2013/09/03 15:37:30, flackr wrote: > LGTM Thanks. If you want you can also trigger ...
7 years, 3 months ago (2013-09-03 15:43:18 UTC) #5
flackr
On 2013/09/03 15:43:18, Rafał Chłodnicki wrote: > On 2013/09/03 15:37:30, flackr wrote: > > LGTM ...
7 years, 3 months ago (2013-09-03 18:46:12 UTC) #6
Rafał Chłodnicki
On 2013/09/03 18:46:12, flackr wrote: > > If you want you can also trigger bots ...
7 years, 3 months ago (2013-09-03 18:52:39 UTC) #7
flackr
On 2013/09/03 18:52:39, Rafał Chłodnicki wrote: > On 2013/09/03 18:46:12, flackr wrote: > > > ...
7 years, 3 months ago (2013-09-03 19:13:05 UTC) #8
Rafał Chłodnicki
On 2013/09/03 19:13:05, flackr wrote: > On 2013/09/03 18:52:39, Rafał Chłodnicki wrote: > > On ...
7 years, 3 months ago (2013-09-03 19:14:59 UTC) #9
flackr
Committed manually as r135.
7 years, 3 months ago (2013-09-03 21:04:18 UTC) #10
flackr
7 years, 3 months ago (2013-09-03 21:05:25 UTC) #11
Message was sent while issue was closed.
Now that this is in grit, you can put up a CL for chromium to pull grit r135 in
the DEPS file.

Powered by Google App Engine
This is Rietveld 408576698