Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1163)

Unified Diff: content/renderer/browser_plugin/browser_plugin.cc

Issue 23591016: BrowserPlugin/WebView - Move plugin lifetime to DOM (Chromium-side) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update BrowserPlugin tests to reflect new behaviour. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin.cc
diff --git a/content/renderer/browser_plugin/browser_plugin.cc b/content/renderer/browser_plugin/browser_plugin.cc
index 587412bb747dd9510fcad725741fcfcffbbc6b2c..6fac1445efa63ab7aa8d227458b8fa169c6be9ba 100644
--- a/content/renderer/browser_plugin/browser_plugin.cc
+++ b/content/renderer/browser_plugin/browser_plugin.cc
@@ -885,6 +885,10 @@ blink::WebPluginContainer* BrowserPlugin::container() const {
return container_;
}
+void BrowserPlugin::containerDidDetachFromParent() {
+ EnableCompositing(false);
+}
+
bool BrowserPlugin::initialize(WebPluginContainer* container) {
if (!container)
return false;
@@ -1384,4 +1388,6 @@ bool BrowserPlugin::HandleMouseLockedInputEvent(
return true;
}
+bool BrowserPlugin::shouldPersist() const { return true; }
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698