Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 23591016: BrowserPlugin/WebView - Move plugin lifetime to DOM (Chromium-side) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update BrowserPlugin tests to reflect new behaviour. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/test/data/browser_plugin_embedder_late_attach.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 3b80b812232672744b132c36550550c569f78818..9573d4d8eb56e4d085620a562708ebd0be640b97 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -1249,6 +1249,13 @@ RenderFrameImpl::createWorkerPermissionClientProxy(blink::WebFrame* frame) {
this, frame);
}
+bool RenderFrameImpl::canCreatePluginWithoutRenderer(
Charlie Reis 2014/04/08 18:51:48 nit: Please put this after cookieJar so that it's
wjmaclean 2014/04/09 16:50:03 Done.
Charlie Reis 2014/04/09 19:09:09 I don't see an updated patch. Please upload the n
+ const blink::WebString& mimeType) {
+ // At present we only support this for BrowserPlugin, but we can add
+ // additional plugin types later.
+ return base::UTF16ToASCII(mimeType) == kBrowserPluginMimeType;
+}
+
blink::WebCookieJar* RenderFrameImpl::cookieJar(blink::WebFrame* frame) {
DCHECK(!frame_ || frame_ == frame);
return &cookie_jar_;
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/test/data/browser_plugin_embedder_late_attach.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698