| 
    
      
  | 
  
 Chromium Code Reviews
        
  DescriptionAdd repro for crash when opening window with --allow-insecure-localhost.
BUG=635833
Committed: https://crrev.com/4adf82fd048f68f63308bbb0dd25063cd220237a
Cr-Commit-Position: refs/heads/master@{#420555}
   
  Patch Set 1 #
      Total comments: 2
      
     
  
  Patch Set 2 : review comment #Messages
    Total messages: 20 (12 generated)
     
  
  
 The CQ bit was checked by jam@chromium.org to run a CQ dry run 
 Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... 
 jam@chromium.org changed reviewers: + estark@chromium.org 
 
 Thanks! lgtm with a suggestion https://codereview.chromium.org/2358983004/diff/1/chrome/browser/ssl/ssl_brow... File chrome/browser/ssl/ssl_browser_tests.cc (right): https://codereview.chromium.org/2358983004/diff/1/chrome/browser/ssl/ssl_brow... chrome/browser/ssl/ssl_browser_tests.cc:3248: class SSLUITestAlllowInsecureHost : public SSLUITest { There's already SSLUITestIgnoreLocalhostCertErrors if you want to use that instead. 
 The CQ bit was unchecked by commit-bot@chromium.org 
 Dry run: This issue passed the CQ dry run. 
 https://codereview.chromium.org/2358983004/diff/1/chrome/browser/ssl/ssl_brow... File chrome/browser/ssl/ssl_browser_tests.cc (right): https://codereview.chromium.org/2358983004/diff/1/chrome/browser/ssl/ssl_brow... chrome/browser/ssl/ssl_browser_tests.cc:3248: class SSLUITestAlllowInsecureHost : public SSLUITest { On 2016/09/22 20:34:03, estark wrote: > There's already SSLUITestIgnoreLocalhostCertErrors if you want to use that > instead. Done 
 The CQ bit was checked by jam@chromium.org 
 The patchset sent to the CQ was uploaded after l-g-t-m from estark@chromium.org Link to the patchset: https://codereview.chromium.org/2358983004/#ps20001 (title: "review comment") 
 CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... 
 The CQ bit was unchecked by commit-bot@chromium.org 
 Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) 
 The CQ bit was checked by jam@chromium.org 
 The patchset sent to the CQ was uploaded after l-g-t-m from estark@chromium.org Link to the patchset: https://codereview.chromium.org/2358983004/#ps40001 (title: "review comment") 
 Patchset #2 (id:20001) has been deleted 
 CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... 
 
            
              
                Message was sent while issue was closed.
              
            
             
          
        Committed patchset #2 (id:40001) 
 
            
              
                Message was sent while issue was closed.
              
            
             
          
        Description was changed from ========== Add repro for crash when opening window with --allow-insecure-localhost. BUG=635833 ========== to ========== Add repro for crash when opening window with --allow-insecure-localhost. BUG=635833 Committed: https://crrev.com/4adf82fd048f68f63308bbb0dd25063cd220237a Cr-Commit-Position: refs/heads/master@{#420555} ========== 
 
            
              
                Message was sent while issue was closed.
              
            
             
          
        Patchset 2 (id:??) landed as https://crrev.com/4adf82fd048f68f63308bbb0dd25063cd220237a Cr-Commit-Position: refs/heads/master@{#420555}  | 
    
