Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2358983004: Add repro for crash when opening window with --allow-insecure-localhost. (Closed)

Created:
4 years, 3 months ago by jam
Modified:
4 years, 3 months ago
Reviewers:
estark
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add repro for crash when opening window with --allow-insecure-localhost. BUG=635833 Committed: https://crrev.com/4adf82fd048f68f63308bbb0dd25063cd220237a Cr-Commit-Position: refs/heads/master@{#420555}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/browser/ssl/ssl_browser_tests.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
jam
4 years, 3 months ago (2016-09-22 20:12:35 UTC) #4
estark
Thanks! lgtm with a suggestion https://codereview.chromium.org/2358983004/diff/1/chrome/browser/ssl/ssl_browser_tests.cc File chrome/browser/ssl/ssl_browser_tests.cc (right): https://codereview.chromium.org/2358983004/diff/1/chrome/browser/ssl/ssl_browser_tests.cc#newcode3248 chrome/browser/ssl/ssl_browser_tests.cc:3248: class SSLUITestAlllowInsecureHost : public ...
4 years, 3 months ago (2016-09-22 20:34:04 UTC) #5
jam
https://codereview.chromium.org/2358983004/diff/1/chrome/browser/ssl/ssl_browser_tests.cc File chrome/browser/ssl/ssl_browser_tests.cc (right): https://codereview.chromium.org/2358983004/diff/1/chrome/browser/ssl/ssl_browser_tests.cc#newcode3248 chrome/browser/ssl/ssl_browser_tests.cc:3248: class SSLUITestAlllowInsecureHost : public SSLUITest { On 2016/09/22 20:34:03, ...
4 years, 3 months ago (2016-09-22 22:25:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358983004/20001
4 years, 3 months ago (2016-09-22 22:25:59 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/282953)
4 years, 3 months ago (2016-09-22 22:48:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358983004/40001
4 years, 3 months ago (2016-09-23 02:09:55 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 3 months ago (2016-09-23 02:48:12 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 02:50:06 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4adf82fd048f68f63308bbb0dd25063cd220237a
Cr-Commit-Position: refs/heads/master@{#420555}

Powered by Google App Engine
This is Rietveld 408576698