Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 2358983004: Add repro for crash when opening window with --allow-insecure-localhost. (Closed)
Patch Set: review comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <utility> 5 #include <utility>
6 6
7 #include "base/base_switches.h" 7 #include "base/base_switches.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/bind_helpers.h" 9 #include "base/bind_helpers.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 3227 matching lines...) Expand 10 before | Expand all | Expand 10 after
3238 content::TestNavigationObserver observer(tab); 3238 content::TestNavigationObserver observer(tab);
3239 EXPECT_TRUE(ExecuteScript(tab, "history.pushState({}, '', '');")); 3239 EXPECT_TRUE(ExecuteScript(tab, "history.pushState({}, '', '');"));
3240 observer.Wait(); 3240 observer.Wait();
3241 CheckAuthenticatedState(tab, AuthState::NONE); 3241 CheckAuthenticatedState(tab, AuthState::NONE);
3242 3242
3243 chrome::GoBack(browser(), WindowOpenDisposition::CURRENT_TAB); 3243 chrome::GoBack(browser(), WindowOpenDisposition::CURRENT_TAB);
3244 content::WaitForLoadStop(tab); 3244 content::WaitForLoadStop(tab);
3245 CheckAuthenticatedState(tab, AuthState::NONE); 3245 CheckAuthenticatedState(tab, AuthState::NONE);
3246 } 3246 }
3247 3247
3248 // Regression test for http://crbug.com/635833 (crash when a window with no
3249 // NavigationEntry commits).
3250 IN_PROC_BROWSER_TEST_F(SSLUITestIgnoreLocalhostCertErrors,
3251 NoCrashOnLoadWithNoNavigationEntry) {
3252 ASSERT_TRUE(embedded_test_server()->Start());
3253
3254 ui_test_utils::NavigateToURL(
3255 browser(), embedded_test_server()->GetURL("/ssl/google.html"));
3256 WebContents* tab = browser()->tab_strip_model()->GetActiveWebContents();
3257 ASSERT_TRUE(content::ExecuteScript(tab, "window.open()"));
3258 }
3259
3248 // TODO(jcampan): more tests to do below. 3260 // TODO(jcampan): more tests to do below.
3249 3261
3250 // Visit a page over https that contains a frame with a redirect. 3262 // Visit a page over https that contains a frame with a redirect.
3251 3263
3252 // XMLHttpRequest insecure content in synchronous mode. 3264 // XMLHttpRequest insecure content in synchronous mode.
3253 3265
3254 // XMLHttpRequest insecure content in asynchronous mode. 3266 // XMLHttpRequest insecure content in asynchronous mode.
3255 3267
3256 // XMLHttpRequest over bad ssl in synchronous mode. 3268 // XMLHttpRequest over bad ssl in synchronous mode.
3257 3269
3258 // XMLHttpRequest over OK ssl in synchronous mode. 3270 // XMLHttpRequest over OK ssl in synchronous mode.
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698