Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: android_webview/native/popup_touch_handle_drawable.cc

Issue 2358893002: Remove DIP scale from PopupTouchHandleDrawable (Closed)
Patch Set: Fixed formatting Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/native/popup_touch_handle_drawable.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/native/popup_touch_handle_drawable.cc
diff --git a/android_webview/native/popup_touch_handle_drawable.cc b/android_webview/native/popup_touch_handle_drawable.cc
index dd8e31b9dde0ca3c04c44fe095f176b8686b52df..d46122cc8e0ab2ab48e4a0ff0ea80a5134ecf82a 100644
--- a/android_webview/native/popup_touch_handle_drawable.cc
+++ b/android_webview/native/popup_touch_handle_drawable.cc
@@ -14,10 +14,8 @@ namespace android_webview {
PopupTouchHandleDrawable::PopupTouchHandleDrawable(
JNIEnv* env,
jobject obj,
- float dip_scale,
float horizontal_padding_ratio)
: java_ref_(env, obj)
- , dip_scale_(dip_scale)
, drawable_horizontal_padding_ratio_(horizontal_padding_ratio) {
DCHECK(!java_ref_.is_empty());
}
@@ -61,9 +59,7 @@ void PopupTouchHandleDrawable::SetOrigin(const gfx::PointF& origin) {
JNIEnv* env = base::android::AttachCurrentThread();
ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
if (!obj.is_null()) {
- const gfx::PointF origin_pix = gfx::ScalePoint(origin, dip_scale_);
- Java_PopupTouchHandleDrawable_setOrigin(env, obj, origin_pix.x(),
- origin_pix.y());
+ Java_PopupTouchHandleDrawable_setOrigin(env, obj, origin.x(), origin.y());
}
}
@@ -80,12 +76,11 @@ gfx::RectF PopupTouchHandleDrawable::GetVisibleBounds() const {
ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
if (obj.is_null())
return gfx::RectF();
- gfx::RectF unscaled_rect(
- Java_PopupTouchHandleDrawable_getPositionX(env, obj),
- Java_PopupTouchHandleDrawable_getPositionY(env, obj),
- Java_PopupTouchHandleDrawable_getVisibleWidth(env, obj),
- Java_PopupTouchHandleDrawable_getVisibleHeight(env, obj));
- return gfx::ScaleRect(unscaled_rect, 1.f / dip_scale_);
+ return gfx::RectF(
+ Java_PopupTouchHandleDrawable_getOriginXDip(env, obj),
+ Java_PopupTouchHandleDrawable_getOriginYDip(env, obj),
+ Java_PopupTouchHandleDrawable_getVisibleWidthDip(env, obj),
+ Java_PopupTouchHandleDrawable_getVisibleHeightDip(env, obj));
}
float PopupTouchHandleDrawable::GetDrawableHorizontalPaddingRatio() const {
@@ -94,13 +89,9 @@ float PopupTouchHandleDrawable::GetDrawableHorizontalPaddingRatio() const {
static jlong Init(JNIEnv* env,
const JavaParamRef<jobject>& obj,
- const JavaParamRef<jobject>& content_view_core,
- const jfloat dip_scale,
const jfloat horizontal_padding_ratio) {
- DCHECK(content_view_core.obj());
return reinterpret_cast<intptr_t>(
- new PopupTouchHandleDrawable(env, obj, dip_scale,
- horizontal_padding_ratio));
+ new PopupTouchHandleDrawable(env, obj, horizontal_padding_ratio));
}
} // namespace content
« no previous file with comments | « android_webview/native/popup_touch_handle_drawable.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698