Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2358843002: Conditionally insert gl_PointSize into shaders. (Closed)

Created:
4 years, 3 months ago by bsalomon
Modified:
4 years, 3 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : minor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -37 lines) Patch
M src/gpu/GrProgramDesc.h View 1 3 chunks +11 lines, -16 lines 0 comments Download
M src/gpu/GrProgramDesc.cpp View 1 2 chunks +10 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 chunks +13 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLGpuProgramCache.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLPathRendering.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/glsl/GrGLSLVertexShaderBuilder.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M src/gpu/instanced/GLInstancedRendering.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkPipelineState.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
bsalomon
4 years, 3 months ago (2016-09-21 15:29:46 UTC) #3
egdaniel
lgtm
4 years, 3 months ago (2016-09-21 16:02:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358843002/20001
4 years, 3 months ago (2016-09-21 17:30:21 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 17:53:27 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2eda5b3a65f54105ae3776160373eed5500c515f

Powered by Google App Engine
This is Rietveld 408576698