Issue 23588002: cleanup api callbacks now that handles are never returned directly

Issue 23588002: cleanup api callbacks now that handles are never returned directly (Closed)

Created:
7 years, 3 months ago by dcarney

Modified:
7 years, 3 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

cleanup api callbacks now that handles are never returned directly R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16360

Patch Set 2 : nits #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -259 lines)			Patch
M	src/arm/macro-assembler-arm.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View		2 chunks	+0 lines, -10 lines	0 comments	Download
M	src/arm/simulator-arm.cc	View		6 chunks	+21 lines, -74 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View		4 chunks	+4 lines, -19 lines	0 comments	Download
M	src/assembler.h	View		1 chunk	+6 lines, -23 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View		3 chunks	+2 lines, -3 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View		3 chunks	+6 lines, -57 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View		3 chunks	+12 lines, -18 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View		3 chunks	+1 line, -33 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1	6 chunks	+4 lines, -19 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM with nits. https://chromiumcodereview.appspot.com/23588002/diff/1/src/x64/stub-cache-x64.cc File src/x64/stub-cache-x64.cc (right): https://chromiumcodereview.appspot.com/23588002/diff/1/src/x64/stub-cache-x64.cc#newcode500 src/x64/stub-cache-x64.cc:500: #elif defined(_WIN64) Perhaps we should merge ...

7 years, 3 months ago (2013-08-27 12:43:57 UTC) #2

dcarney

https://chromiumcodereview.appspot.com/23588002/diff/1/src/x64/stub-cache-x64.cc File src/x64/stub-cache-x64.cc (right): https://chromiumcodereview.appspot.com/23588002/diff/1/src/x64/stub-cache-x64.cc#newcode500 src/x64/stub-cache-x64.cc:500: #elif defined(_WIN64) On 2013/08/27 12:43:57, Sven Panne wrote: > ...

7 years, 3 months ago (2013-08-27 12:52:05 UTC) #3

dcarney

7 years, 3 months ago (2013-08-27 13:41:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r16360 (presubmit successful).

Expand Messages | Collapse Messages