Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: src/arm/macro-assembler-arm.h

Issue 23588002: cleanup api callbacks now that handles are never returned directly (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: nits Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1093 matching lines...) Expand 10 before | Expand all | Expand 10 after
1104 1104
1105 // Calls an API function. Allocates HandleScope, extracts returned value 1105 // Calls an API function. Allocates HandleScope, extracts returned value
1106 // from handle and propagates exceptions. Restores context. stack_space 1106 // from handle and propagates exceptions. Restores context. stack_space
1107 // - space to be unwound on exit (includes the call JS arguments space and 1107 // - space to be unwound on exit (includes the call JS arguments space and
1108 // the additional space allocated for the fast call). 1108 // the additional space allocated for the fast call).
1109 void CallApiFunctionAndReturn(ExternalReference function, 1109 void CallApiFunctionAndReturn(ExternalReference function,
1110 Address function_address, 1110 Address function_address,
1111 ExternalReference thunk_ref, 1111 ExternalReference thunk_ref,
1112 Register thunk_last_arg, 1112 Register thunk_last_arg,
1113 int stack_space, 1113 int stack_space,
1114 bool returns_handle,
1115 int return_value_offset_from_fp); 1114 int return_value_offset_from_fp);
1116 1115
1117 // Jump to a runtime routine. 1116 // Jump to a runtime routine.
1118 void JumpToExternalReference(const ExternalReference& builtin); 1117 void JumpToExternalReference(const ExternalReference& builtin);
1119 1118
1120 // Invoke specified builtin JavaScript function. Adds an entry to 1119 // Invoke specified builtin JavaScript function. Adds an entry to
1121 // the unresolved list if the name does not resolve. 1120 // the unresolved list if the name does not resolve.
1122 void InvokeBuiltin(Builtins::JavaScript id, 1121 void InvokeBuiltin(Builtins::JavaScript id,
1123 InvokeFlag flag, 1122 InvokeFlag flag,
1124 const CallWrapper& call_wrapper = NullCallWrapper()); 1123 const CallWrapper& call_wrapper = NullCallWrapper());
(...skipping 347 matching lines...) Expand 10 before | Expand all | Expand 10 after
1472 #define __FILE_LINE__ __FILE__ ":" CODE_COVERAGE_TOSTRING(__LINE__) 1471 #define __FILE_LINE__ __FILE__ ":" CODE_COVERAGE_TOSTRING(__LINE__)
1473 #define ACCESS_MASM(masm) masm->stop(__FILE_LINE__); masm-> 1472 #define ACCESS_MASM(masm) masm->stop(__FILE_LINE__); masm->
1474 #else 1473 #else
1475 #define ACCESS_MASM(masm) masm-> 1474 #define ACCESS_MASM(masm) masm->
1476 #endif 1475 #endif
1477 1476
1478 1477
1479 } } // namespace v8::internal 1478 } } // namespace v8::internal
1480 1479
1481 #endif // V8_ARM_MACRO_ASSEMBLER_ARM_H_ 1480 #endif // V8_ARM_MACRO_ASSEMBLER_ARM_H_
OLDNEW
« no previous file with comments | « no previous file | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698