Issue 23587024: Revert revision 27542 "Make Dart_IdentityEqual live up to its spec and not leak boxing implementati…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23587024: Revert revision 27542 "Make Dart_IdentityEqual live up to its spec and not leak boxing implementati… (Closed)

Created:
7 years, 3 months ago by ricow1

Modified:
7 years, 3 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Revert revision 27542 "Make Dart_IdentityEqual live up to its spec and not leak boxing implementation detail." This is causing checked mode failures on all vm bots. Committed: https://code.google.com/p/dart/source/detail?r=27545

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -52 lines)			Patch
M	runtime/include/dart_api.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/lib/identical.cc	View	1 chunk	+15 lines, -1 line	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 chunk	+2 lines, -12 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	3 chunks	+0 lines, -14 lines	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ricow1

Committed patchset #1 manually as r27545 (presubmit successful).

7 years, 3 months ago (2013-09-17 06:29:55 UTC) #3

ricow1

On 2013/09/17 06:29:55, ricow1 wrote: > Committed patchset #1 manually as r27545 (presubmit successful). Just ...

7 years, 3 months ago (2013-09-17 07:12:57 UTC) #4

rmacnak

7 years, 3 months ago (2013-09-18 17:52:30 UTC) #5

Message was sent while issue was closed.

On 2013/09/17 07:12:57, ricow1 wrote:
> On 2013/09/17 06:29:55, ricow1 wrote:
> > Committed patchset #1 manually as r27545 (presubmit successful).
> 
> Just fyi, this only failed in checked mode on linux, on windows it actually
> failed to compile, see:
>
http://build.chromium.org/p/client.dart/builders/vm-win32-release/builds/1977...

Belated LGTM on the revert.

Just to keep a record somewhere, this fails to build on Windows because of a
warning over 0.0/0.0 and crashes on x64 due to a bug in the intrinsic version of
double comparison.

Expand Messages | Collapse Messages