Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 23587024: Revert revision 27542 "Make Dart_IdentityEqual live up to its spec and not leak boxing implementati… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl_test.cc
===================================================================
--- runtime/vm/dart_api_impl_test.cc (revision 27544)
+++ runtime/vm/dart_api_impl_test.cc (working copy)
@@ -199,11 +199,6 @@
// Different objects.
EXPECT(!Dart_IdentityEquals(five, seven));
- // Case where identical() is not the same as pointer equality.
- Dart_Handle nan1 = Dart_NewDouble(0.0/0.0);
- Dart_Handle nan2 = Dart_NewDouble(0.0/0.0);
- EXPECT(Dart_IdentityEquals(nan1, nan2));
-
// Non-instance objects.
{
Isolate* isolate = Isolate::Current();
@@ -214,10 +209,6 @@
EXPECT(Dart_IdentityEquals(class1, class1));
EXPECT(!Dart_IdentityEquals(class1, class2));
-
- // Mix instance and non-instance.
- EXPECT(!Dart_IdentityEquals(class1, nan1));
- EXPECT(!Dart_IdentityEquals(nan1, class1));
}
}
@@ -239,11 +230,6 @@
// Different objects.
EXPECT_VALID(Dart_ObjectEquals(five, seven, &equal));
EXPECT(!equal);
-
- // Case where == is not the same as pointer equality.
- Dart_Handle nan = Dart_NewDouble(0.0/0.0);
- EXPECT_VALID(Dart_ObjectEquals(nan, nan, &equal));
- EXPECT(!equal);
}
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698