Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2358693002: Mojo C++ bindings: make InterfaceEndpointClient observe message loop destruction. (Closed)

Created:
4 years, 3 months ago by yzshen1
Modified:
4 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: make InterfaceEndpointClient observe message loop destruction. Otherwise, there is no guarantee that we will issue connection error notification on message loop destruction. The observer of mojo::Watcher will need to be removed. BUG=594244, 604762 Committed: https://crrev.com/421e2d6ed8e31318f8e8e653d2d892d9b58815df Cr-Commit-Position: refs/heads/master@{#420069}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M mojo/public/cpp/bindings/interface_endpoint_client.h View 1 4 chunks +9 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/interface_endpoint_client.cc View 1 2 chunks +17 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 3 months ago (2016-09-20 22:32:26 UTC) #5
Ken Rockot(use gerrit already)
lgtm
4 years, 3 months ago (2016-09-21 14:13:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358693002/20001
4 years, 3 months ago (2016-09-21 15:33:16 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-21 15:38:21 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 15:42:04 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/421e2d6ed8e31318f8e8e653d2d892d9b58815df
Cr-Commit-Position: refs/heads/master@{#420069}

Powered by Google App Engine
This is Rietveld 408576698