Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Unified Diff: content/browser/gpu/gpu_data_manager_impl_private.cc

Issue 2358683002: Android: enable/disable WebRTC HW H264 with a flag. (Closed)
Patch Set: adopt enum instead and address other comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | content/public/browser/gpu_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/gpu/gpu_data_manager_impl_private.cc
diff --git a/content/browser/gpu/gpu_data_manager_impl_private.cc b/content/browser/gpu/gpu_data_manager_impl_private.cc
index 96beb775df9b3160d7e407bce87e51bc90d2cc36..4cb3a471021c8a78a2bf8e9253cf82fa9950894e 100644
--- a/content/browser/gpu/gpu_data_manager_impl_private.cc
+++ b/content/browser/gpu/gpu_data_manager_impl_private.cc
@@ -683,6 +683,13 @@ void GpuDataManagerImplPrivate::AppendRendererCommandLine(
command_line->AppendSwitch(switches::kDisableWebRtcHWEncoding);
#endif
+// Disable HW encoding by default on Android.
+#if defined(ENABLE_WEBRTC) && defined(OS_ANDROID)
+ if (!command_line->HasSwitch(switches::kDisableWebRtcHWEncoding)) {
+ command_line->AppendSwitch(switches::kDisableWebRtcHWEncoding);
+ }
Ken Russell (switch to Gerrit) 2016/10/06 23:23:09 Is there a reason to not just handle this with a n
braveyao 2016/10/06 23:31:05 There was one in software_rendering_list_json.cc w
Ken Russell (switch to Gerrit) 2016/10/07 00:46:51 Yes, please just add the entry back in software_re
braveyao 2016/10/07 00:59:23 Done.
+#endif
+
#if defined(USE_AURA)
if (!CanUseGpuBrowserCompositor())
command_line->AppendSwitch(switches::kDisableGpuCompositing);
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | content/public/browser/gpu_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698